From: Chenming C <ccm@ccm.ink>
To: dev@dpdk.org
Cc: yipeng1.wang@intel.com, sameh.gobriel@intel.com,
bruce.richardson@intel.com, vladimir.medvedkin@intel.com
Subject: [PATCH] lib/hash: fix the return value description of rte_hash
Date: Mon, 27 Jun 2022 21:11:21 +0800 [thread overview]
Message-ID: <1656335481-238112-1-git-send-email-ccm@ccm.ink> (raw)
The rte_hash lookup can return ZERO which is not a positive value.
Signed-off-by: Chenming C <ccm@ccm.ink>
---
lib/hash/rte_hash.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/hash/rte_hash.h b/lib/hash/rte_hash.h
index 7fa9702..1bf1aac 100644
--- a/lib/hash/rte_hash.h
+++ b/lib/hash/rte_hash.h
@@ -288,7 +288,7 @@ struct rte_hash *
* @return
* - -EINVAL if the parameters are invalid.
* - -ENOSPC if there is no space in the hash for this key.
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key. This
* unique key id may be larger than the user specified entry count
* when RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD flag is set.
@@ -312,7 +312,7 @@ struct rte_hash *
* @return
* - -EINVAL if the parameters are invalid.
* - -ENOSPC if there is no space in the hash for this key.
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key. This
* unique key ID may be larger than the user specified entry count
* when RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD flag is set.
@@ -343,7 +343,7 @@ struct rte_hash *
* @return
* - -EINVAL if the parameters are invalid.
* - -ENOENT if the key is not found.
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key, and is the same
* value that was returned when the key was added.
*/
@@ -375,7 +375,7 @@ struct rte_hash *
* @return
* - -EINVAL if the parameters are invalid.
* - -ENOENT if the key is not found.
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key, and is the same
* value that was returned when the key was added.
*/
@@ -442,7 +442,7 @@ struct rte_hash *
* @param data
* Output with pointer to data returned from the hash table.
* @return
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key, and is the same
* value that was returned when the key was added.
* - -EINVAL if the parameters are invalid.
@@ -467,7 +467,7 @@ struct rte_hash *
* @param data
* Output with pointer to data returned from the hash table.
* @return
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key, and is the same
* value that was returned when the key was added.
* - -EINVAL if the parameters are invalid.
@@ -490,7 +490,7 @@ struct rte_hash *
* @return
* - -EINVAL if the parameters are invalid.
* - -ENOENT if the key is not found.
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key, and is the same
* value that was returned when the key was added.
*/
@@ -512,7 +512,7 @@ struct rte_hash *
* @return
* - -EINVAL if the parameters are invalid.
* - -ENOENT if the key is not found.
- * - A positive value that can be used by the caller as an offset into an
+ * - A non-negative value that can be used by the caller as an offset into an
* array of user data. This value is unique for this key, and is the same
* value that was returned when the key was added.
*/
--
1.8.3.1
next reply other threads:[~2022-06-27 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 13:11 Chenming C [this message]
2023-07-06 22:58 ` Stephen Hemminger
2024-03-01 17:10 ` Vladimir Medvedkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1656335481-238112-1-git-send-email-ccm@ccm.ink \
--to=ccm@ccm.ink \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).