From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A08F1A0524; Sun, 6 Dec 2020 16:49:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E70C42B8D; Sun, 6 Dec 2020 16:49:46 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9F698295B for ; Sun, 6 Dec 2020 16:49:45 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E9F8B5C0195; Sun, 6 Dec 2020 10:49:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 06 Dec 2020 10:49:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= fT067lyaqufrIuNzu4AknrkAoSXje75act77W+jP/hE=; b=sGc16gcP8Cqz3w8L vziUjpVjqLJD+iRW40XJXlENCCV3y7Nu+XDnq11mddpKxNohz3M81EhuKpXN1n79 jsFfyL61sFPPN3WhILr4tN1lBD4YqqHR5w+JSd7paXOosRuVIAPs96XRsS+I895o +j4pV2HqHmigkFL1Dxk9uChq3Gqrh04KD9oPgkggLf0J71VwU7v+LPZdoT5mfLeS rgWc3whrRUaLSdR8JmZkmJ7jjxmVtBDaVk6S4OfabFaFSEwGvw1Bhu8p903uyZlt mjWQB+FPCi6KqkqZolAW9s1VmLcD/hE2ADr+bTxjQdplt1DwL1uuHhyFYnnR8Dvw fguKSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=fT067lyaqufrIuNzu4AknrkAoSXje75act77W+jP/ hE=; b=pdMbBj/kbCYu62I6q9FZV+me9S2EcL9hx3RXUv7XpOVQOeDCKqTvylSjy 28UQNLdWg1AzYm/3nftPL3KKV17j2kHb00L63dmXRdjviz5lRBxZaYqCSFPD30Rm lklNtpEbSHfv6+ni2DuiKA5bDMSHyuyf9KMY27Re/W6B5bZwyHiKTyzdvEUL3y/y Iqe6FnbE16i0uFzQY6dmdl0vI46dioeCqEH0ERYUZ1y1fA88bMnwb+OPxHJz2ZhC aetx+kN/Kv/iTvqQ8TwMmPq+tezLkyyXKmlsbCUslQlAtwOgwhxRxolhdAPpyItb TWypvgyR2ak7NoIp80NfYG9f0FO5A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejvddgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A6911080057; Sun, 6 Dec 2020 10:49:42 -0500 (EST) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, beilei.xing@intel.com, jia.guo@intel.com, talshn@nvidia.com Date: Sun, 06 Dec 2020 16:49:40 +0100 Message-ID: <1656459.hZBu3j2uRN@thomas> In-Reply-To: <20201205011020.6276-3-pallavi.kadam@intel.com> References: <20201205011020.6276-1-pallavi.kadam@intel.com> <20201205011020.6276-3-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/12/2020 02:10, Pallavi Kadam: > --- a/drivers/net/meson.build > +++ b/drivers/net/meson.build > @@ -1,9 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > -if is_windows > - subdir_done() > -endif > > drivers = ['af_packet', > 'af_xdp', > @@ -56,6 +53,12 @@ drivers = ['af_packet', > 'virtio', > 'vmxnet3', > ] > + > +if is_windows > + drivers = ['i40e', > + ] > +endif Let's not add an alternative list please. I prefer disabling compilation in other drivers. > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > @@ -33,6 +33,7 @@ if is_windows > 'malloc_heap.c', > 'rte_malloc.c', > 'eal_common_timer.c', > + 'rte_random.c', > 'rte_service.c', > ) > subdir_done() > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index 89166acd7..428201872 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -124,6 +124,7 @@ EXPORTS > rte_memzone_reserve_bounded > rte_memzone_walk > rte_openlog_stream > + rte_rand > rte_realloc > rte_rtm_supported > rte_service_attr_get > diff --git a/lib/librte_eal/windows/include/rte_windows.h b/lib/librte_eal/windows/include/rte_windows.h > index b82af34f6..822922c11 100644 > --- a/lib/librte_eal/windows/include/rte_windows.h > +++ b/lib/librte_eal/windows/include/rte_windows.h > @@ -18,6 +18,11 @@ > #define WIN32_LEAN_AND_MEAN > #endif > > +#ifdef __clang__ > +#undef _m_prefetchw > +#define _m_prefetchw __m_prefetchw > +#endif These changes are not specific to i40e, please separate.