From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D41181B1C1 for ; Fri, 6 Oct 2017 22:19:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 317F420DA5; Fri, 6 Oct 2017 16:19:24 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 06 Oct 2017 16:19:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=MzmLOb7dG7JzupQ iEQzVWdl7jJbMn3pdYRDQa05hCcs=; b=q2RtqkJQ/UCTL9OjMFO9UVLDDgg2yqa BaWKiwcWqh0SeA19Dj6Cf5DUjHd91a0U/MySeLkIvIHHbsLhptsptmqs2+noYFpp Avbjjoq2ACGRBFNgPPZ4TeNSjJQFNnlkFZVUHZnJSaF1qFCV4WeCWsHkkXEB8lPR uYkZRZE2Qctw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=MzmLOb7dG7JzupQiEQzVWdl7jJbMn3pdYRDQa05hCcs=; b=Wph4smik G47kSdUvmUIoMp4JHsbB8NvX6gA9k1dKqrgyZ3XAIq9XkQxnp+inSFwlfNlj9rLw AOb/dBWQ0iVvAHQUitC1DYcg3G7xZLQ0wnU4QSSxEMsqgL2scP3Ld8wXm4VSdntR kB/+lQ6lpJAzKoyPSjGWR+uUQNYHwL3OCNvjYJ/Sa6YNLv3qM26AjfMhLs+YnOVr FzJ8cuhGmlyz4CBj/R0gEmpotCiunNv4Ou+UtTOFnXXkE/AGiLdINLmP3j6Fs+UJ LwPGEr3NbzSKVIQvFXf+kD5TJrcpHqN5SEUDCokSqNfhOgTD4z5vPx8u6EfsZSMC PGSXaeqLCA9RCA== X-ME-Sender: X-Sasl-enc: Uk1CHV+BA29mHmo4Bs5f8BSsnU7OrkG2drT4yjfpH6RH 1507321163 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D4864247AE; Fri, 6 Oct 2017 16:19:23 -0400 (EDT) From: Thomas Monjalon To: "liucheng (J)" Cc: dev@dpdk.org, sergio.gonzalez.monroy@intel.com Date: Fri, 06 Oct 2017 22:19:22 +0200 Message-ID: <16571873.8VHJB6EtNZ@xps> In-Reply-To: <8B0A0B0226AB0F47A8D0EBBBBA1F005102BC7F7D@DGGEML502-MBX.china.huawei.com> References: <8B0A0B0226AB0F47A8D0EBBBBA1F005102BC7F7D@DGGEML502-MBX.china.huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH]librte_eal:add heap lock in malloc_heap_get_stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 20:19:25 -0000 Hi, We need a Signed-off-by to process your contribution. Thank you +Cc sergio.gonzalez.monroy@intel.com 21/09/2017 05:19, liucheng (J): > There is no lock in function malloc_heap_get_stats. When we call this function, the elem may free by other thread. > > the call stack: > Core was generated by `ovs-vswitchd unix:/usr/var/run/openvswitch/db.sock -vconsole:emer -vsyslog:info'. > Program terminated with signal 11, Segmentation fault. > #0 malloc_heap_get_stats (heap=0x7f3abf08ee1c, socket_stats=socket_stats@entry=0x7ffce811ffc0) at /usr/src/debug/dpdk-16.04/lib/librte_eal/common/malloc_heap.c:198 > 198 socket_stats->heap_freesz_bytes += elem->size; > (gdb) bt > #0 malloc_heap_get_stats (heap=0x7f3abf08ee1c, socket_stats=socket_stats@entry=0x7ffce811ffc0) at /usr/src/debug/dpdk-16.04/lib/librte_eal/common/malloc_heap.c:198 > #1 0x00007f3abd6d6299 in rte_malloc_get_socket_stats (socket=socket@entry=0, socket_stats=socket_stats@entry=0x7ffce811ffc0) at /usr/src/debug/dpdk-16.04/lib/librte_eal/common/rte_malloc.c:214 > ...... > > lib/librte_eal/common/malloc_heap.c | 3 +++ > lib/librte_eal/common/malloc_heap.h | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-)