From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1B33F1B2A1 for ; Mon, 6 Nov 2017 10:08:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 76E5920A22; Mon, 6 Nov 2017 04:08:25 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 06 Nov 2017 04:08:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=1xPiseqlSFSKYnMW4RdhWKrFZ4 npEaJDGD4easSTDSI=; b=do+u8J6PgkHoQUOJp+Vf0IxooihwHuBcWGJ4MytDxN S0HLuLAl/QrfnBbxDFGlPr0or6wVdkIMEjA0n0I3BWMufVw74M4WrhDjFeQN2TQG NSGws6pwU7exI6P5rrkri9Sf3dBqjrJQ5mKQ57jkvEsyBhxSFInl7Q1Dw631RBhX Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1xPise qlSFSKYnMW4RdhWKrFZ4npEaJDGD4easSTDSI=; b=odLHUCiGZqfF6XwafnzFst WigoGAtSsYsV17XbUHf/Q0tNme6/GIn1Ezg5TPdWds/D5VT6nDE/PG8DClLYy4t3 ieIBvrW6eukq7vGE6Y+LvcgNF8PRTuZzxqlF//PEfR4pGoIBZnq01uLDB3M8JpWh yYXsEiaCqxGuxuZ+mN6C9QIhyIOSHxmVo8yiwavTWbUOvdZO9T4b5LG142M5B8wL 6ynY524z3XG9FWKBxNIOdpgHdNn+S4F9dZ5BP+DYus2poT0jiOwk0KZvmG/IZsaP ujA1w++f+f9FoJq9REKHK9pMXcJCgfJyobsgnqaRMDerkpdf+Xs7qfIFTaNOv+yw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30D127FAB2; Mon, 6 Nov 2017 04:08:25 -0500 (EST) From: Thomas Monjalon To: santosh Cc: olivier.matz@6wind.com, sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org Date: Mon, 06 Nov 2017 10:08:24 +0100 Message-ID: <1658152.eYkLdl3WOf@xps> In-Reply-To: <020f79b0-8d81-7e5f-fd28-089f38e27723@caviumnetworks.com> References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com> <3304743.b7VfCBXbgQ@xps> <020f79b0-8d81-7e5f-fd28-089f38e27723@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 02/15] mem: introduce IOVA type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 09:08:26 -0000 06/11/2017 09:51, santosh: > > On Monday 06 November 2017 02:07 PM, Thomas Monjalon wrote: > > 06/11/2017 06:38, santosh: > >> On Monday 06 November 2017 07:11 AM, Thomas Monjalon wrote: > >>> The IO virtual addresses may be used instead of physical addresses. > >>> As IOVA is more generic, it should be used in most places instead > >>> of physical address wording. > >>> > >>> Signed-off-by: Thomas Monjalon > >>> --- > >>> +/** > >>> + * IO virtual address type. > >>> + * When the physical addressing mode is in use, > >>> + * the translation from a virtual address to a physical address > >>> + * is a direct mapping, i.e. the same value. > >>> + */ > >> I guess - that description applicable for iova=va mode > >> and for iova=pa mode - Need to do explicit virt2phy translation. > >> I believe you mis-wrote - s/physical addressing mode/virtual addressing mode. > > Not sure to understand your comment. > > Let me reword the description to be less ambiguous: > > > > * When the physical addressing mode (IOVA as PA) is in use, > > * the translation from an IO virtual address (IOVA) to a physical address > > * is a direct mapping, i.e. the same value. > > * Otherwise, in virtual mode (IOVA as VA), an IOMMU may do the translation. > > > > Is this description correct? > > > Yes. Good, so I can change the description with this one and add your ack, right?