From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 003FFA0548;
Thu, 11 Aug 2022 10:24:50 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0B65E42B98;
Thu, 11 Aug 2022 10:24:45 +0200 (CEST)
Received: from njjs-sys-mailin05.njjs.baidu.com (mx313.baidu.com
[180.101.52.140])
by mails.dpdk.org (Postfix) with ESMTP id A09124014F
for <dev@dpdk.org>; Mon, 1 Aug 2022 16:50:03 +0200 (CEST)
Received: from bjhw-sys-rpm015653cc5.bjhw.baidu.com
(bjhw-sys-rpm015653cc5.bjhw.baidu.com [10.227.53.39])
by njjs-sys-mailin05.njjs.baidu.com (Postfix) with ESMTP id 371D4CF8003E;
Mon, 1 Aug 2022 22:50:01 +0800 (CST)
Received: from localhost (localhost [127.0.0.1])
by bjhw-sys-rpm015653cc5.bjhw.baidu.com (Postfix) with ESMTP id 20983D9932;
Mon, 1 Aug 2022 22:50:01 +0800 (CST)
From: Mao YingMing <maoyingming@baidu.com>
To: dev@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: [PATCH] net/bnxt: fix null pointer dereference in
bnxt_hwrm_port_led_cfg()
Date: Mon, 1 Aug 2022 22:50:01 +0800
Message-Id: <1659365401-41425-1-git-send-email-maoyingming@baidu.com>
X-Mailer: git-send-email 1.7.1
X-Mailman-Approved-At: Thu, 11 Aug 2022 10:24:41 +0200
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
From: maoyingming <maoyingming@baidu.com>
VFs's "bp->leds" is allways null, check bp->leds is
not null before use bp->leds->num_leds.
segfault backtrace in trex program when use VF:
11: bnxt_hwrm_port_led_cfg (bp=0x23ffb2140, led_on=true)
10: bnxt_dev_led_on_op (dev=0x22d7780 <rte_eth_devices>)
9: rte_eth_led_on (port_id=0)
8: DpdkTRexPortAttr::set_led (this=0x23b6ce0, on=true)
7: DpdkTRexPortAttr::DpdkTRexPortAttr
6: CTRexExtendedDriverBnxt::create_port_attr
5: CPhyEthIF::Create
4: CGlobalTRex::device_start
3: CGlobalTRex::Create
2: main_test
1: main
Fixes: d4d5a04 ("net/bnxt: fix unnecessary memory allocation")
Cc: stable@dpdk.org
Signed-off-by: Mao YingMing <maoyingming@baidu.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 9c52573..41e6067 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -4535,7 +4535,7 @@ int bnxt_hwrm_port_led_cfg(struct bnxt *bp, bool led_on)
uint16_t duration = 0;
int rc, i;
- if (!bp->leds->num_leds || BNXT_VF(bp))
+ if (BNXT_VF(bp) || (!bp->leds) || (!bp->leds->num_leds))
return -EOPNOTSUPP;
HWRM_PREP(&req, HWRM_PORT_LED_CFG, BNXT_USE_CHIMP_MB);
--
1.8.3.1