* [dpdk-dev] [PATCH] net/cxgbe: fix memory leak
@ 2017-09-05 8:46 Congwen Zhang
2017-09-06 9:25 ` Rahul Lakkireddy
0 siblings, 1 reply; 3+ messages in thread
From: Congwen Zhang @ 2017-09-05 8:46 UTC (permalink / raw)
To: rahul.lakkireddy; +Cc: dev, Congwen Zhang
In function t4_wr_mbox_meat_timeout(), Dynamic memory stored
in 'temp' not free when the functon return, It possible memory
leak.
Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
drivers/net/cxgbe/base/t4_hw.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c
index a8ccea0..013d996 100644
--- a/drivers/net/cxgbe/base/t4_hw.c
+++ b/drivers/net/cxgbe/base/t4_hw.c
@@ -403,6 +403,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
t4_os_atomic_list_del(&entry, &adap->mbox_list,
&adap->mbox_lock);
t4_report_fw_error(adap);
+ free(temp);
return (pcie_fw & F_PCIE_FW_ERR) ? -ENXIO : -EBUSY;
}
@@ -446,6 +447,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
&adap->mbox_list,
&adap->mbox_lock));
t4_report_fw_error(adap);
+ free(temp);
return (v == X_MBOWNER_FW ? -EBUSY : -ETIMEDOUT);
}
@@ -546,6 +548,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
T4_OS_MBOX_LOCKING(
t4_os_atomic_list_del(&entry, &adap->mbox_list,
&adap->mbox_lock));
+ free(temp);
return -G_FW_CMD_RETVAL((int)res);
}
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/cxgbe: fix memory leak
2017-09-05 8:46 [dpdk-dev] [PATCH] net/cxgbe: fix memory leak Congwen Zhang
@ 2017-09-06 9:25 ` Rahul Lakkireddy
2017-09-06 14:44 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Rahul Lakkireddy @ 2017-09-06 9:25 UTC (permalink / raw)
To: Congwen Zhang
Cc: dev, Kumar Sanghvi, Nirranjan Kirubaharan, Indranil Choudhury
On Tuesday, September 09/05/17, 2017 at 14:16:57 +0530, Congwen Zhang wrote:
> In function t4_wr_mbox_meat_timeout(), Dynamic memory stored
> in 'temp' not free when the functon return, It possible memory
> leak.
>
> Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
> ---
> drivers/net/cxgbe/base/t4_hw.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c
> index a8ccea0..013d996 100644
> --- a/drivers/net/cxgbe/base/t4_hw.c
> +++ b/drivers/net/cxgbe/base/t4_hw.c
> @@ -403,6 +403,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
> t4_os_atomic_list_del(&entry, &adap->mbox_list,
> &adap->mbox_lock);
> t4_report_fw_error(adap);
> + free(temp);
> return (pcie_fw & F_PCIE_FW_ERR) ? -ENXIO : -EBUSY;
> }
>
> @@ -446,6 +447,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
> &adap->mbox_list,
> &adap->mbox_lock));
> t4_report_fw_error(adap);
> + free(temp);
> return (v == X_MBOWNER_FW ? -EBUSY : -ETIMEDOUT);
> }
>
> @@ -546,6 +548,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
> T4_OS_MBOX_LOCKING(
> t4_os_atomic_list_del(&entry, &adap->mbox_list,
> &adap->mbox_lock));
> + free(temp);
> return -G_FW_CMD_RETVAL((int)res);
> }
> }
> --
> 1.8.3.1
>
Thanks for the fix!
Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/cxgbe: fix memory leak
2017-09-06 9:25 ` Rahul Lakkireddy
@ 2017-09-06 14:44 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-09-06 14:44 UTC (permalink / raw)
To: Rahul Lakkireddy, Congwen Zhang
Cc: dev, Kumar Sanghvi, Nirranjan Kirubaharan, Indranil Choudhury
On 9/6/2017 10:25 AM, Rahul Lakkireddy wrote:
> On Tuesday, September 09/05/17, 2017 at 14:16:57 +0530, Congwen Zhang wrote:
>> In function t4_wr_mbox_meat_timeout(), Dynamic memory stored
>> in 'temp' not free when the functon return, It possible memory
>> leak.
Fixes: 3bd122eef2cc ("cxgbe/base: add hardware API for Chelsio T5 series
adapters")
Cc: stable@dpdk.org
>> Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
> Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-06 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 8:46 [dpdk-dev] [PATCH] net/cxgbe: fix memory leak Congwen Zhang
2017-09-06 9:25 ` Rahul Lakkireddy
2017-09-06 14:44 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).