DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ethdev: ownership change log message priority change
@ 2018-08-01 17:43 Stephen Hemminger
  2018-08-02  6:40 ` Matan Azrad
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2018-08-01 17:43 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

Changing ownership of a port is a normal event, and should
not be logged at ERR priority. Downgrade to a DEBUG message.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 2e40c3fba99a..c7ab15722f98 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -463,7 +463,7 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id,
 
 	port_owner->id = new_owner->id;
 
-	RTE_ETHDEV_LOG(ERR, "Port %u owner is %s_%016"PRIx64"\n",
+	RTE_ETHDEV_LOG(DEBUG, "Port %u owner is %s_%016"PRIx64"\n",
 		port_id, new_owner->name, new_owner->id);
 
 	return 0;
-- 
2.18.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: ownership change log message priority change
  2018-08-01 17:43 [dpdk-dev] [PATCH] ethdev: ownership change log message priority change Stephen Hemminger
@ 2018-08-02  6:40 ` Matan Azrad
  2018-08-02  7:00   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2018-08-02  6:40 UTC (permalink / raw)
  To: Stephen Hemminger, dev



From: Stephen Hemminger
> Changing ownership of a port is a normal event, and should not be logged at
> ERR priority. Downgrade to a DEBUG message.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Matan Azrad <matan@mellanox.com>
> ---
>  lib/librte_ethdev/rte_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 2e40c3fba99a..c7ab15722f98 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -463,7 +463,7 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const
> uint64_t old_owner_id,
> 
>  	port_owner->id = new_owner->id;
> 
> -	RTE_ETHDEV_LOG(ERR, "Port %u owner is %s_%016"PRIx64"\n",
> +	RTE_ETHDEV_LOG(DEBUG, "Port %u owner is %s_%016"PRIx64"\n",
>  		port_id, new_owner->name, new_owner->id);
> 
>  	return 0;
> --
> 2.18.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: ownership change log message priority change
  2018-08-02  6:40 ` Matan Azrad
@ 2018-08-02  7:00   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-08-02  7:00 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Matan Azrad

02/08/2018 08:40, Matan Azrad:
> 
> From: Stephen Hemminger
> > Changing ownership of a port is a normal event, and should not be logged at
> > ERR priority. Downgrade to a DEBUG message.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Matan Azrad <matan@mellanox.com>

Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")

Applied with this title:
	ethdev: decrease log level of ownership change

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-02  7:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 17:43 [dpdk-dev] [PATCH] ethdev: ownership change log message priority change Stephen Hemminger
2018-08-02  6:40 ` Matan Azrad
2018-08-02  7:00   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).