From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 7CD82374F for ; Wed, 1 Mar 2017 12:00:23 +0100 (CET) Received: by mail-wr0-f175.google.com with SMTP id u48so27487172wrc.0 for ; Wed, 01 Mar 2017 03:00:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=LTBeFi4JJHLS5+1HRAlPw+FCF5ho55Kub9OtJBtZemU=; b=OWT70kwkyLpNOPmn2sA1NlZIO8nTrYWNdb950T0ZwOes2A8j2wmh2sDbwmwex/aYBK AwTF0FphNHOdmEBR6LUvZ06IPyh4CP1jkixLCH5ty3+TLuYT5XOVkQRUgjzER0UA541x 8r6yYobG2I6g8w8SLBKWjz+LcUrIkFANmjv+se5AmaiNAPCBpBou3f5XZg2brH6ZSGGQ Trv4fFLViN8oPUIHW3KI5SSeTq+IwMYLQWJVN9nvJvyzMOD2EU/RZmbL3n+8PtTn5SQx WdQ2Iggh530rH+mz7Eb8QOG5s4KXqh45WVK0z3SqJlwSfiayxSIwlqfMNoFQieRZoLbz 9EmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=LTBeFi4JJHLS5+1HRAlPw+FCF5ho55Kub9OtJBtZemU=; b=Q2c/E2UrcY6mI9UvDXXRhR8zKo0X5Qv/dMaf13LIxn54gj/nYWRHGCt/VR3YpEUxBo 2JEJgWwZzfjgQO2FWh5Dr6qyzart3GL/fjDguaO5Aqs9F0iNERTTiTLOZkey2oDhDDBa pYgY0wIqUNj06PfXT9NBzrGuQ3we+Yn263X22VzvN41LOH52/MbkQ8qYJkXBr0wtuXzb Iv24OQIoHumQF+cenhh3v0lQtp98vEME7Fx8d6+zIY/BpM7EarFZdvtIlQd3JicYpe31 teLYvzEX2tYtNmKsZILjyZ77czLcbng1Ekr9ZTf+mf2b2klOB5RUqeql9EjGsdOrXOyQ QKtA== X-Gm-Message-State: AMke39kSPUREFCv1V6LOBSyy6j6pFSpyn+8hXDl68OMWwRXWweCJju2lFaR0Qi9xDb9Ap2Iy X-Received: by 10.223.148.35 with SMTP id 32mr7162143wrq.18.1488366023194; Wed, 01 Mar 2017 03:00:23 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m29sm6079175wrm.38.2017.03.01.03.00.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 03:00:22 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain , Hemant Agrawal Cc: dev@dpdk.org, Ferruh Yigit , nhorman@tuxdriver.com Date: Wed, 01 Mar 2017 12:00:21 +0100 Message-ID: <1662518.dF45MxJRnv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <23fc7ab5-1d1b-183e-7997-6e078d49a499@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv7 03/47] common/dpaa2: adding qbman driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 11:00:23 -0000 2017-02-28 05:27, Shreyansh Jain: > From: Ferruh Yigit > > On 2/27/2017 10:01 AM, Shreyansh Jain wrote: > > > On Friday 24 February 2017 03:28 PM, Ferruh Yigit wrote: > > >> We can go with option (1) now, since these are not real APIs to user > > >> application, it can be possible to change them if better solution found. > > >> > > >> Do you think is it good idea to have different naming syntax for those > > >> libraries to clarify they are for PMD internal usage? > > >> > > > > > > Indeed. Current name is librte_common_dpaa2_*. > > > Do you think librte_drvlib_dpaa2 or librte_drvlib_dpaa2_pmd is better? > > > > common vs drvlib may not be different for who don't know about these > > libraries, what about using "internal" or "private" kind of keyword? > > I am ok with librte_pvtlib_dpaa2_pmd or librte_pvtlib_dpaa2. Sounds fine? > ('internal' is too long and its abbreviation 'int' doesn't make it easier > to read. :D ) There is already "lib" in "librte". What about librte_internal_dpaa2_ prefix? Internal is really the best word as you are requesting DPDK to host libraries used only for your drivers. I thought you agreed to host them outside of the DPDK repository. What is your reason to keep pushing in DPDK?