From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92A65A0471 for ; Mon, 15 Jul 2019 22:50:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8801B2C60; Mon, 15 Jul 2019 22:50:25 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BD6092C23 for ; Mon, 15 Jul 2019 22:50:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 00B7621EAD; Mon, 15 Jul 2019 16:50:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 15 Jul 2019 16:50:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4hSEVa/QxUpBqJn3ditCt8HCDLuFdp9kiOjPEGJq4+w=; b=k45bpQgd8U4a 5xFzdhJMsUzdEe1ZqWjST5mk6Dttqv/1mQWPsqwpES6lERR1+aQtyxNu3g5Osufr fgI6fZCQeqwINwaD5THX7PbEbCmtKY/6F2Xzs4zCMOoB4tWOv9WIlw2LOiTZvymt RR5hSquHzkQQPHQ9jZOzOzAWsuNsm0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=4hSEVa/QxUpBqJn3ditCt8HCDLuFdp9kiOjPEGJq4 +w=; b=vpzr3QpY3vZq56LloGcMh06O87wgqTGg2JM6q0mWhDfpSfytJgIPKC7gc ScyG2JzPLGa5bB0XhG5f9Q9pJquEVupZDj6Bo3L0yOcpZS+qqvCwcYkrgGhZDrYg 6XIZpYW7Gcz9VidHE3RA7XSvQN018of1jYl2VcobXe/Jb7Ln8ulokdvxsNktDewp b4QOWMGrwhxykfHkdqpSBCt9VACX8d+Hsxt2k7mQ1uZYhJ8IjLdd9DmNZmnrqNe3 E9VWLD0vGnatW+l3YY1lfEAdNH2uUNDBB4P5z3YEkSGpKS1aHOrn+J3Ge3UmYRRt dCPQsWsC5mGJ26MJFAL+kizgtzKbw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrheekgddugeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3B96F38008A; Mon, 15 Jul 2019 16:50:22 -0400 (EDT) From: Thomas Monjalon To: Yangchao Zhou Cc: dev@dpdk.org, Ferruh Yigit , stephen@networkplumber.org, sodey@rbbn.com, Junxiao Shi Date: Mon, 15 Jul 2019 22:50:21 +0200 Message-ID: <1662932.6VjZo4KV3e@xps> In-Reply-To: References: <20190312092232.93640-1-zhouyates@gmail.com> <421b6eaa-beac-bed4-fe3e-6cf8647406e9@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] kni: fix possible kernel crash with va2pa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/07/2019 09:46, Ferruh Yigit: > On 7/10/2019 9:09 PM, Ferruh Yigit wrote: > > On 6/25/2019 4:04 PM, Yangchao Zhou wrote: > >> va2pa depends on the physical address and virtual address offset of > >> current mbuf. It may get the wrong physical address of next mbuf which > >> allocated in another hugepage segment. > >> > >> In rte_mempool_populate_default(), trying to allocate whole block of > >> contiguous memory could be failed. Then, it would reserve memory in > >> several memzones that have different physical address and virtual address > >> offsets. The rte_mempool_populate_default() is used by > >> rte_pktmbuf_pool_create(). > >> > >> Fixes: 8451269e6d7b ("kni: remove continuous memory restriction") > >> > >> Signed-off-by: Yangchao Zhou > > > > Overall looks good to me, not from this patch but can you please check below > > comment too. > > Also there is a comment from Junxiao, lets clear it before the ack. > > > > Acked-by: Ferruh Yigit The commit log does not really explained neither the use case nor the solution. But as you acked it... Applied, thanks