From: Luca Boccassi <luca.boccassi@microsoft.com> Necessary to get build flags from DKMS. See: https://git.dpdk.org/dpdk/commit/?id=816d967717 Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com> --- linux/igb_uio/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/linux/igb_uio/Kbuild b/linux/igb_uio/Kbuild index 98c98fe..3ab85c4 100644 --- a/linux/igb_uio/Kbuild +++ b/linux/igb_uio/Kbuild @@ -1 +1,2 @@ +ccflags-y := $(MODULE_CFLAGS) obj-m := igb_uio.o -- 2.20.1
28/10/2020 19:15, luca.boccassi@gmail.com: > From: Luca Boccassi <luca.boccassi@microsoft.com> > > Necessary to get build flags from DKMS. > > See: > > https://git.dpdk.org/dpdk/commit/?id=816d967717 [...] > --- a/linux/igb_uio/Kbuild > +++ b/linux/igb_uio/Kbuild > @@ -1 +1,2 @@ > +ccflags-y := $(MODULE_CFLAGS) > obj-m := igb_uio.o Yes this patch was not migrated because I though it was referring to a DPDK-specific variable. So you mean MODULE_CFLAGS is from the kernel build system?
On Thu, 29 Oct 2020, 20:58 Thomas Monjalon, <thomas@monjalon.net> wrote: > 28/10/2020 19:15, luca.boccassi@gmail.com: > > From: Luca Boccassi <luca.boccassi@microsoft.com> > > > > Necessary to get build flags from DKMS. > > > > See: > > > > https://git.dpdk.org/dpdk/commit/?id=816d967717 > [...] > > --- a/linux/igb_uio/Kbuild > > +++ b/linux/igb_uio/Kbuild > > @@ -1 +1,2 @@ > > +ccflags-y := $(MODULE_CFLAGS) > > obj-m := igb_uio.o > > Yes this patch was not migrated because I though it was referring > to a DPDK-specific variable. > So you mean MODULE_CFLAGS is from the kernel build system? > Yeah dkms uses it >
From: Luca Boccassi <bluca@debian.org> With the legacy build system MODULE_CFLAGS can be set to pass compiler flags specific for the kernel modules builds. This is used currently by Ubuntu and Debian. Set ccflags-y in the Kbuild to achieve the same result with Meson, and to keep backward compatbility with older scripts. Fixes regression in Ubuntu/Debian when the Kbuild is included in the DKMS source package, as DKMS will pick it up silently by default if present, causing the MODULE_CFLAGS to be ignored. Fixes: a52f4574f798 ("igb_uio: build with meson") Cc: stable@dpdk.org Signed-off-by: Luca Boccassi <bluca@debian.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- v2: backported original commit instead of making a new one linux/igb_uio/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/linux/igb_uio/Kbuild b/linux/igb_uio/Kbuild index 98c98fe..3ab85c4 100644 --- a/linux/igb_uio/Kbuild +++ b/linux/igb_uio/Kbuild @@ -1 +1,2 @@ +ccflags-y := $(MODULE_CFLAGS) obj-m := igb_uio.o -- 2.27.0
11/11/2020 13:16, luca.boccassi@gmail.com:
> From: Luca Boccassi <bluca@debian.org>
>
> With the legacy build system MODULE_CFLAGS can be set to pass compiler
> flags specific for the kernel modules builds.
> This is used currently by Ubuntu and Debian.
> Set ccflags-y in the Kbuild to achieve the same result with Meson, and
> to keep backward compatbility with older scripts.
>
> Fixes regression in Ubuntu/Debian when the Kbuild is included in the
> DKMS source package, as DKMS will pick it up silently by default if
> present, causing the MODULE_CFLAGS to be ignored.
>
> Fixes: a52f4574f798 ("igb_uio: build with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: backported original commit instead of making a new one
Applied with original commit date,
and simpler explanation from the v1
because meson/make history is not relevant in this repo.