From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C5C6A054A; Fri, 23 Sep 2022 04:33:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AB0C400D7; Fri, 23 Sep 2022 04:33:44 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id F40C24003C for ; Fri, 23 Sep 2022 04:33:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663900423; x=1695436423; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=eJLAwUh/qFRepv7zVxJIjW4kcj5kik1rcIUrkQGuMN8=; b=DpO/WpSiNhFD0RnS3Cw6KubPBbOe7+4Zf0eK7jMvLAUjuDlroPqZtyzW KXlTyB2VYOECdPfRHPkefqvwdGbG2Pr5JR5UGrbfBbfR+P8gtMH+QDs36 wh9bXYVM/EErYxn+Ch9ZoVang2GwAq/o287skrbZyYD1cgCOaaIRsnwhc tgjXwniR94jG41SkxBMgj7RnxbjPkrGMOJFma+GEiT3DAPHVC3jy5JiTO a3mVyXISr/N7e6iB+AZYPj0nhfTKgVOGG1hAYqMlLT85ah2YBRuybIN7c B72RZvhDkTIfrqqATxzz+PjzDtMYQzgthbDs3kUzL2tHf6utzy/k0w2Fs w==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="298090594" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="298090594" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 19:33:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="597704261" Received: from dpdk-dipei.sh.intel.com ([10.67.110.251]) by orsmga006.jf.intel.com with ESMTP; 22 Sep 2022 19:33:32 -0700 From: Andy Pei To: dev@dpdk.org Cc: chenbo.xia@intel.com, maxime.coquelin@redhat.com Subject: [PATCH v2] vhost: use dedicated variable for vhost message result code Date: Fri, 23 Sep 2022 10:32:49 +0800 Message-Id: <1663900369-294749-1-git-send-email-andy.pei@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1658110002-191064-1-git-send-email-andy.pei@intel.com> References: <1658110002-191064-1-git-send-email-andy.pei@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently in function vhost_user_msg_handler, variable ret is used to store both vhost msg result code and function call return value. After this patch, variable ret is used only to store function call return value, a new dedicated variable msg_result is used to store vhost msg result. This can improve readability. Signed-off-by: Andy Pei --- lib/vhost/vhost_user.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index 0182090..6d93495 100644 --- a/lib/vhost/vhost_user.c +++ b/lib/vhost/vhost_user.c @@ -2954,6 +2954,7 @@ static int is_vring_iotlb(struct virtio_net *dev, struct vhu_msg_context ctx; vhost_message_handler_t *msg_handler; struct rte_vdpa_device *vdpa_dev; + int msg_result = RTE_VHOST_MSG_RESULT_OK; int ret; int unlock_required = 0; bool handled; @@ -3046,8 +3047,8 @@ static int is_vring_iotlb(struct virtio_net *dev, handled = false; if (dev->extern_ops.pre_msg_handle) { RTE_BUILD_BUG_ON(offsetof(struct vhu_msg_context, msg) != 0); - ret = (*dev->extern_ops.pre_msg_handle)(dev->vid, &ctx); - switch (ret) { + msg_result = (*dev->extern_ops.pre_msg_handle)(dev->vid, &ctx); + switch (msg_result) { case RTE_VHOST_MSG_RESULT_REPLY: send_vhost_reply(dev, fd, &ctx); /* Fall-through */ @@ -3065,12 +3066,12 @@ static int is_vring_iotlb(struct virtio_net *dev, goto skip_to_post_handle; if (!msg_handler->accepts_fd && validate_msg_fds(dev, &ctx, 0) != 0) { - ret = RTE_VHOST_MSG_RESULT_ERR; + msg_result = RTE_VHOST_MSG_RESULT_ERR; } else { - ret = msg_handler->callback(&dev, &ctx, fd); + msg_result = msg_handler->callback(&dev, &ctx, fd); } - switch (ret) { + switch (msg_result) { case RTE_VHOST_MSG_RESULT_ERR: VHOST_LOG_CONFIG(dev->ifname, ERR, "processing %s failed.\n", @@ -3095,11 +3096,11 @@ static int is_vring_iotlb(struct virtio_net *dev, } skip_to_post_handle: - if (ret != RTE_VHOST_MSG_RESULT_ERR && + if (msg_result != RTE_VHOST_MSG_RESULT_ERR && dev->extern_ops.post_msg_handle) { RTE_BUILD_BUG_ON(offsetof(struct vhu_msg_context, msg) != 0); - ret = (*dev->extern_ops.post_msg_handle)(dev->vid, &ctx); - switch (ret) { + msg_result = (*dev->extern_ops.post_msg_handle)(dev->vid, &ctx); + switch (msg_result) { case RTE_VHOST_MSG_RESULT_REPLY: send_vhost_reply(dev, fd, &ctx); /* Fall-through */ @@ -3118,7 +3119,7 @@ static int is_vring_iotlb(struct virtio_net *dev, "vhost message (req: %d) was not handled.\n", request); close_msg_fds(&ctx); - ret = RTE_VHOST_MSG_RESULT_ERR; + msg_result = RTE_VHOST_MSG_RESULT_ERR; } /* @@ -3127,17 +3128,16 @@ static int is_vring_iotlb(struct virtio_net *dev, * VHOST_USER_NEED_REPLY was cleared in send_vhost_reply(). */ if (ctx.msg.flags & VHOST_USER_NEED_REPLY) { - ctx.msg.payload.u64 = ret == RTE_VHOST_MSG_RESULT_ERR; + ctx.msg.payload.u64 = msg_result == RTE_VHOST_MSG_RESULT_ERR; ctx.msg.size = sizeof(ctx.msg.payload.u64); ctx.fd_num = 0; send_vhost_reply(dev, fd, &ctx); - } else if (ret == RTE_VHOST_MSG_RESULT_ERR) { + } else if (msg_result == RTE_VHOST_MSG_RESULT_ERR) { VHOST_LOG_CONFIG(dev->ifname, ERR, "vhost message handling failed.\n"); ret = -1; goto unlock; } - ret = 0; for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; bool cur_ready = vq_is_ready(dev, vq); -- 1.8.3.1