From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Chaoyong He <chaoyong.he@corigine.com>
Subject: [PATCH 06/24] net/nfp: add the offload support of VLAN item
Date: Fri, 7 Oct 2022 10:18:28 +0800 [thread overview]
Message-ID: <1665109126-16201-7-git-send-email-chaoyong.he@corigine.com> (raw)
In-Reply-To: <1665109126-16201-1-git-send-email-chaoyong.he@corigine.com>
Add the corresponding data structure and logics, to support
the offload of VLAN item.
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
doc/guides/nics/features/nfp.ini | 1 +
doc/guides/rel_notes/release_22_11.rst | 1 +
drivers/net/nfp/nfp_flow.c | 46 ++++++++++++++++++++++++++++++++++
drivers/net/nfp/nfp_flow.h | 2 ++
4 files changed, 50 insertions(+)
diff --git a/doc/guides/nics/features/nfp.ini b/doc/guides/nics/features/nfp.ini
index 194fe64..f0ecae2 100644
--- a/doc/guides/nics/features/nfp.ini
+++ b/doc/guides/nics/features/nfp.ini
@@ -29,6 +29,7 @@ Usage doc = Y
[rte_flow items]
eth = Y
port_id = Y
+vlan = Y
[rte_flow actions]
count = Y
diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
index e36a711..5163264 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -108,6 +108,7 @@ New Features
Add the support of rte_flow pattern items as follow:
* Ethernet
+ * Single VLAN
Add the support of rte_flow actions as follow:
diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c
index ec021f0..b063b96 100644
--- a/drivers/net/nfp/nfp_flow.c
+++ b/drivers/net/nfp/nfp_flow.c
@@ -530,6 +530,10 @@ struct nfp_mask_id_entry {
ethdev->data->dev_private;
key_ls->port = rte_cpu_to_be_32(representor->port_id);
break;
+ case RTE_FLOW_ITEM_TYPE_VLAN:
+ PMD_DRV_LOG(DEBUG, "RTE_FLOW_ITEM_TYPE_VLAN detected");
+ key_ls->vlan = NFP_FLOWER_MASK_VLAN_CFI;
+ break;
default:
PMD_DRV_LOG(ERR, "Item type %d not supported.", item->type);
return -ENOTSUP;
@@ -641,12 +645,42 @@ struct nfp_mask_id_entry {
return 0;
}
+static int
+nfp_flow_merge_vlan(struct rte_flow *nfp_flow,
+ __rte_unused char **mbuf_off,
+ const struct rte_flow_item *item,
+ const struct nfp_flow_item_proc *proc,
+ bool is_mask)
+{
+ struct nfp_flower_meta_tci *meta_tci;
+ const struct rte_flow_item_vlan *spec;
+ const struct rte_flow_item_vlan *mask;
+
+ spec = item->spec;
+ if (spec == NULL) {
+ PMD_DRV_LOG(DEBUG, "nfp flow merge vlan: no item->spec!");
+ return 0;
+ }
+
+ mask = item->mask ? item->mask : proc->mask_default;
+ if (is_mask) {
+ meta_tci = (struct nfp_flower_meta_tci *)nfp_flow->payload.mask_data;
+ meta_tci->tci |= mask->tci;
+ } else {
+ meta_tci = (struct nfp_flower_meta_tci *)nfp_flow->payload.unmasked_data;
+ meta_tci->tci |= spec->tci;
+ }
+
+ return 0;
+}
+
/* Graph of supported items and associated process function */
static const struct nfp_flow_item_proc nfp_flow_item_proc_list[] = {
[RTE_FLOW_ITEM_TYPE_END] = {
.next_item = NEXT_ITEM(RTE_FLOW_ITEM_TYPE_ETH),
},
[RTE_FLOW_ITEM_TYPE_ETH] = {
+ .next_item = NEXT_ITEM(RTE_FLOW_ITEM_TYPE_VLAN),
.mask_support = &(const struct rte_flow_item_eth){
.hdr = {
.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
@@ -659,6 +693,18 @@ struct nfp_mask_id_entry {
.mask_sz = sizeof(struct rte_flow_item_eth),
.merge = nfp_flow_merge_eth,
},
+ [RTE_FLOW_ITEM_TYPE_VLAN] = {
+ .mask_support = &(const struct rte_flow_item_vlan){
+ .hdr = {
+ .vlan_tci = RTE_BE16(0xefff),
+ .eth_proto = RTE_BE16(0xffff),
+ },
+ .has_more_vlan = 1,
+ },
+ .mask_default = &rte_flow_item_vlan_mask,
+ .mask_sz = sizeof(struct rte_flow_item_vlan),
+ .merge = nfp_flow_merge_vlan,
+ },
};
static int
diff --git a/drivers/net/nfp/nfp_flow.h b/drivers/net/nfp/nfp_flow.h
index f1fbada..f6bd3e4 100644
--- a/drivers/net/nfp/nfp_flow.h
+++ b/drivers/net/nfp/nfp_flow.h
@@ -25,6 +25,8 @@
#define NFP_FL_META_FLAG_MANAGE_MASK (1 << 7)
+#define NFP_FLOWER_MASK_VLAN_CFI (1 << 12)
+
#define NFP_MASK_TABLE_ENTRIES 1024
/* The maximum action list size (in bytes) supported by the NFP. */
--
1.8.3.1
next prev parent reply other threads:[~2022-10-07 2:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 2:18 [PATCH 00/24] add the basic rte_flow offload support of nfp PMD Chaoyong He
2022-10-07 2:18 ` [PATCH 01/24] net/nfp: add the stats process logic in ctrl VNIC service Chaoyong He
2022-10-07 2:18 ` [PATCH 02/24] net/nfp: add the structures and functions for flow offload Chaoyong He
2022-10-07 2:18 ` [PATCH 03/24] net/nfp: add the flow APIs of nfp PMD Chaoyong He
2022-10-07 2:18 ` [PATCH 04/24] net/nfp: add the offload support of basic items Chaoyong He
2022-10-07 2:18 ` [PATCH 05/24] net/nfp: add the offload support of basic actions Chaoyong He
2022-10-07 2:18 ` Chaoyong He [this message]
2022-10-07 2:18 ` [PATCH 07/24] net/nfp: add the offload support of IPv4 item Chaoyong He
2022-10-07 2:18 ` [PATCH 08/24] net/nfp: add the offload support of IPv6 item Chaoyong He
2022-10-07 2:18 ` [PATCH 09/24] net/nfp: add the offload support of TCP item Chaoyong He
2022-10-07 2:18 ` [PATCH 10/24] net/nfp: add the offload support of UDP item Chaoyong He
2022-10-07 2:18 ` [PATCH 11/24] net/nfp: add the offload support of SCTP item Chaoyong He
2022-10-07 2:18 ` [PATCH 12/24] net/nfp: add the offload support of set SRC MAC action Chaoyong He
2022-10-07 2:18 ` [PATCH 13/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-07 2:18 ` [PATCH 14/24] net/nfp: add the offload support of pop VLAN action Chaoyong He
2022-10-07 2:18 ` [PATCH 15/24] net/nfp: add the offload support of push " Chaoyong He
2022-10-07 2:18 ` [PATCH 16/24] net/nfp: add the offload support of set SRC IPv4 action Chaoyong He
2022-10-07 2:18 ` [PATCH 17/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-07 2:18 ` [PATCH 18/24] net/nfp: add the offload support of set SRC IPv6 action Chaoyong He
2022-10-07 2:18 ` [PATCH 19/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-07 2:18 ` [PATCH 20/24] net/nfp: add the offload support of set TP SRC port action Chaoyong He
2022-10-07 2:18 ` [PATCH 21/24] net/nfp: add the offload support of set TP DST " Chaoyong He
2022-10-07 2:18 ` [PATCH 22/24] net/nfp: add the offload support of set TTL action Chaoyong He
2022-10-07 2:18 ` [PATCH 23/24] net/nfp: add the offload support of set IPv4 DSCP action Chaoyong He
2022-10-07 2:18 ` [PATCH 24/24] net/nfp: add the offload support of set IPv6 " Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1665109126-16201-7-git-send-email-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).