From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 5723CC498
 for <dev@dpdk.org>; Wed, 17 Jun 2015 17:25:25 +0200 (CEST)
Received: by wgbhy7 with SMTP id hy7so40057625wgb.2
 for <dev@dpdk.org>; Wed, 17 Jun 2015 08:25:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ILqU5Zds2Vy1mKell5Vzld/QfSL9B01hUQYS3hvewMQ=;
 b=PVEsAxHzOWjNkX00A1A6ycbgdlvF7HwTOZgbGynhxfYwbrQMa0FJ/9Cx9ONNH0MXNs
 tFjOkzMzpnnpIqi0qEkEnsyY1SMwZURnsotjcwpuXV/u9PyVyZnda9Wu2lS3dnjZ0Gxy
 aFbtzm5eY3EHIYCX6p+moAd/jC8dN7I6fsZgzlzqztdKViV6fMNW0uC73Afth3Nx7uUV
 QlmRsgOkZMPnyaxZTZNIu6Cm58PfFZYVhHaN3npOiqdNVQeLui6/qQKCt6PPZ579HCLC
 F9lpIoV+zgtHIF03krFaOCSjQnWGGvFpAUGfeV3RR7xNvfuUotzfDIqBAOPFc8O2B7iA
 x9dg==
X-Gm-Message-State: ALoCoQmi9h/OC8QqhLEVFX4KXon50YUiMbUiqsm1imiLVNVJIr4b0RHmpGuOlrTXYKqBFYSl3xFY
X-Received: by 10.194.61.236 with SMTP id t12mr6881428wjr.59.1434554725157;
 Wed, 17 Jun 2015 08:25:25 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ju2sm8236060wid.12.2015.06.17.08.25.23
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 17 Jun 2015 08:25:24 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>, Pavel Boldin <pboldin@mirantis.com>
Date: Wed, 17 Jun 2015 17:24:24 +0200
Message-ID: <1665929.SfCu3BinAE@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <C37D651A908B024F974696C65296B57B0F476567@SHSMSX101.ccr.corp.intel.com>
References: <1427994080-10163-1-git-send-email-pboldin@mirantis.com>
 <1429184910-30186-5-git-send-email-pboldin@mirantis.com>
 <C37D651A908B024F974696C65296B57B0F476567@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace
	copy-pasted sys_close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2015 15:25:25 -0000

2015-05-07 06:54, Xie, Huawei:
> On 4/16/2015 7:48 PM, Pavel Boldin wrote:
> > +	/* Closing the source_fd */
> > +	ret = sys_close(eventfd_copy.source_fd);
> Pavel:
> Here we close the fd and re-install a new file on this fd later. 
> sys_close does all cleanup.
> But, for instance, if we allocate new fd later, normally it will reuse
> the just freed fds by sys_close, is there issue here? 

Pavel, Huawei,
Could we come to a conclusion on this patch series please?