From: Thomas Monjalon <thomas@monjalon.net>
To: Jie Zhou <jizh@linux.microsoft.com>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v4] rte_metrics: unconditionally exports rte_metrics_tel_xxx functions
Date: Tue, 16 Mar 2021 10:07:12 +0100 [thread overview]
Message-ID: <16659706.GMLzRk6Jzk@thomas> (raw)
In-Reply-To: <1615226739-27419-1-git-send-email-jizh@linux.microsoft.com>
08/03/2021 19:05, Jie Zhou:
> From: Jie Zhou <jizh@microsoft.com>
>
> This patch allows the same set of rte_metrics_tel_* functions to be
> exported no matter JANSSON is available or not, by doing following:
> 1. Leverage dpdk_conf to set configuration flag RTE_HAVE_JANSSON
Changed to RTE_HAS_JANSSON.
> when Jansson dependency is found.
> 2. In rte_metrics_telemetry.c, leverage RTE_HAVE_JANSSON to handle the
> case when JANSSON is not available by adding stubs for all the instances.
> 3. In meson.build, per dpdk\doc\guides\rel_notes\release_20_05.rst,
Changed to use / instead of \
> it is claimed that "Telemetry library is no longer dependent on the
> external Jansson library, which allows Telemetry be enabled by default.",
> thus make the deps and includes of Telemetry as not conditional anymore.
>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
This email address is not the same as above.
Changed to be the same.
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> +#ifdef RTE_HAS_JANSSON
> struct telemetry_metrics_data tel_met_data;
Added space and comments around #ifdef and #else.
Applied with minor changes, thanks.
prev parent reply other threads:[~2021-03-16 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 21:25 [dpdk-dev] [PATCH] rte_metrics: unconditionally export " Jie
2021-02-22 22:24 ` Dmitry Kozlyuk
2021-02-23 10:03 ` Bruce Richardson
2021-02-23 23:01 ` [dpdk-dev] [PATCH v2] rte_metrics: unconditionally exports " Jie Zhou
2021-02-24 10:36 ` Bruce Richardson
2021-02-24 18:46 ` [dpdk-dev] [PATCH v3] " Jie Zhou
2021-03-06 20:18 ` Dmitry Kozlyuk
2021-03-08 18:05 ` [dpdk-dev] [PATCH v4] " Jie Zhou
2021-03-16 9:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16659706.GMLzRk6Jzk@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=jizh@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).