From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1809CA054F; Tue, 16 Mar 2021 10:07:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B6442428A1; Tue, 16 Mar 2021 10:07:17 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id B7DE92428A0 for <dev@dpdk.org>; Tue, 16 Mar 2021 10:07:16 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 40C1D2901; Tue, 16 Mar 2021 05:07:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 16 Mar 2021 05:07:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= aYhOfc0mEmh2mkSg8VZTIInsUz0qUdr0/5gSyDBs5Lw=; b=DqJeOd93ctw/Ot7v aCts1OmzVQ5DeXwzhLPg5+UXCGdjtzyI8WUi4SimKzwnheGQfxmwhGCbKjSq2KGx +hs+aach+gk2xVxF11Lt1te/uMoTHFtw5A7jg0NYh4I7XoQIa/fiydGzsRaViRi9 yatDd/axukvotuY96QE92Tu2h1xVRFvVuziTXYryWmD+LLex0kGCXcEPcWtAIhxI 2KKYGZbxcIGean3HTT+5yFMaPlxKrx1sdF25ER8EDsqcmZ1LtPq7wyizUkwDlvzs kOxV2LPr4+KQ8sfdMQQ+9SlNoR3O7trkUtNeRec7iSKVy/wgvFWdGoRkthOLKvFk /paWDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aYhOfc0mEmh2mkSg8VZTIInsUz0qUdr0/5gSyDBs5 Lw=; b=nSYKrATbubkalwIgoQrRrWets+5HzpuVUHTO0koWHxtIDx1/yDxppScDa kqRT/PT/prPVgMUPfxayTYjJHM8ljl2yYJXmFwV9C0DNKg3bDgKolJr1XcvqE7Y+ kw1vJEuU7U6cLKM+nVWRJC2GysV38Lct9g9nDEhvtHo99yV6YSrLI3Xbjlr3zS9M aSIpUgdWEsJXoUhf15/5nqRiomarqnFVoIYTOLfzW0yPdaEfBxmUw20xCTlJsTVm iVNQL0o6+lsqC3EMMpDFI8AsuJQaqAYLQeGjkXHgzbiojJYtqbG4HbYmzkFyYQLM o6bPDKdOkWilhM2L4SR3r61qKncvg== X-ME-Sender: <xms:QnVQYLrXKNuDkOPuwRdfnS3ZA1o32jGMdlUnZQAxmyF_Dbf9FTR5Tw> <xme:QnVQYFoSo3UHlNuNNUVsEc-FiVH9aFu7Y4QNn6UzJQBfRWQMP7NPMStzrUDVLPG1O ImuigNGG8YA7FGCZQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefuddguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:QnVQYIMERIdD9fO5IxmVk9bE_09h02oKjQ0UQEQqcmFcYztV4lrRJw> <xmx:QnVQYO4Jq7th2VP-3jerdp8a12xE5Rf6PDwEGdA7eX4Vc7cM7Kax9Q> <xmx:QnVQYK7SaloCvnYQc7NnJ6AsIEy3wx0a89VyeBhTHlvJO7k_rcuQuA> <xmx:QnVQYAQl9Mg2PDGtYA_y24SItGGPoKutTXxcD2IZYcDf4bI9Bqhm2g> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D92A624005B; Tue, 16 Mar 2021 05:07:13 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jie Zhou <jizh@linux.microsoft.com> Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com Date: Tue, 16 Mar 2021 10:07:12 +0100 Message-ID: <16659706.GMLzRk6Jzk@thomas> In-Reply-To: <1615226739-27419-1-git-send-email-jizh@linux.microsoft.com> References: <1614192383-20597-1-git-send-email-jizh@linux.microsoft.com> <1615226739-27419-1-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] rte_metrics: unconditionally exports rte_metrics_tel_xxx functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 08/03/2021 19:05, Jie Zhou: > From: Jie Zhou <jizh@microsoft.com> > > This patch allows the same set of rte_metrics_tel_* functions to be > exported no matter JANSSON is available or not, by doing following: > 1. Leverage dpdk_conf to set configuration flag RTE_HAVE_JANSSON Changed to RTE_HAS_JANSSON. > when Jansson dependency is found. > 2. In rte_metrics_telemetry.c, leverage RTE_HAVE_JANSSON to handle the > case when JANSSON is not available by adding stubs for all the instances. > 3. In meson.build, per dpdk\doc\guides\rel_notes\release_20_05.rst, Changed to use / instead of \ > it is claimed that "Telemetry library is no longer dependent on the > external Jansson library, which allows Telemetry be enabled by default.", > thus make the deps and includes of Telemetry as not conditional anymore. > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com> This email address is not the same as above. Changed to be the same. > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> > +#ifdef RTE_HAS_JANSSON > struct telemetry_metrics_data tel_met_data; Added space and comments around #ifdef and #else. Applied with minor changes, thanks.