From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BD49A0560; Tue, 18 Oct 2022 14:59:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A850142836; Tue, 18 Oct 2022 14:58:38 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 0FD21427F4 for ; Tue, 18 Oct 2022 14:58:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666097914; x=1697633914; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=o8f1sWoMenWEr9E6VK1GnKrRShbXo+TYIdd8C7jFeK0=; b=H0ziioDEinnqNnL2fGHAnxjsiyEqlUpHdiCfRWvQAU6JjJRGXMdUjpIa eOtb2a6PiE0IOemJ6ol/xpLqrt7Sa27x3HxLUWY+ul1OChaQjbwLvZt2q /aXsHwTONcc0WYu0z4JMg0B8DRdt+y+pQ3ZefHr0bcVrBJzkpfcj22ATb GPgGiJmliwU55fOBwvSXM2BVMyWP2OoC5OAK1a8HFdpNc1TNKH123x9Iq SSnFRlphkKWmPSd6MCu/wCEc2bK4MjwenME7SCZnkfLSPQ5/JuDMBBJf+ ojWmldyjhBq5/HJS5USjVgdqPdaJTJ9d8DJxP2hW7vPWN9RJI5R1DZUwv w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="307179494" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="307179494" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 05:58:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="733614536" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="733614536" Received: from dpdk-dipei.sh.intel.com ([10.67.110.251]) by fmsmga002.fm.intel.com with ESMTP; 18 Oct 2022 05:58:27 -0700 From: Andy Pei To: dev@dpdk.org Cc: chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com, gang.cao@intel.com, maxime.coquelin@redhat.com Subject: [PATCH v8 09/12] vdpa/ifc: change some driver logic Date: Tue, 18 Oct 2022 20:07:48 +0800 Message-Id: <1666094871-25721-10-git-send-email-andy.pei@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1666094871-25721-1-git-send-email-andy.pei@intel.com> References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Insert internal list element to internal list before register vdpa device, in order to call vdpa ops during vdpa device registration. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index c16e263..8dfd493 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c @@ -1737,17 +1737,20 @@ struct rte_vdpa_dev_info dev_info[] = { } internal->sw_lm = sw_fallback_lm; + pthread_mutex_lock(&internal_list_lock); + TAILQ_INSERT_TAIL(&internal_list, list, next); + pthread_mutex_unlock(&internal_list_lock); + internal->vdev = rte_vdpa_register_device(&pci_dev->device, dev_info[internal->hw.device_type].ops); if (internal->vdev == NULL) { DRV_LOG(ERR, "failed to register device %s", pci_dev->name); + pthread_mutex_lock(&internal_list_lock); + TAILQ_REMOVE(&internal_list, list, next); + pthread_mutex_unlock(&internal_list_lock); goto error; } - pthread_mutex_lock(&internal_list_lock); - TAILQ_INSERT_TAIL(&internal_list, list, next); - pthread_mutex_unlock(&internal_list_lock); - rte_atomic32_set(&internal->started, 1); update_datapath(internal); -- 1.8.3.1