From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4626A0581; Wed, 19 Oct 2022 11:32:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8532B42B71; Wed, 19 Oct 2022 11:32:02 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9240542B75 for ; Wed, 19 Oct 2022 11:31:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666171916; x=1697707916; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=b8O7nBcKdZhrgedYArHj3sKz8TcuYuva7J4a2yZcOfY=; b=X2m0e/Zt4xaUx01mgbPwgSCT0gm7UwBJpBHXJe5jwMdarPtJ6oY22l5T z9iVh1lt3+5El/UywcA5GiXcGoqZF11Zmz4Gv8s2kOVAXjuooYzGKQ5at JNPNGyHt25kPhVgD3aKYy9F2DEL9RCeHXHWddHGIRiKr1pL8NUYbPG2JE jzx8q9f0IhQR3BvwpAy+m3WQvBire7g8GnDcZMQwbt6IwRfoBbBU2AP+U PRJHMTkuuzLkHe5fS2TC0we3JOqyTslvKzC+QtOSSy7bu8riCzpZmGipi lZLIKZk4bIKhZgtSTY1yxbcCTMG7EwcoipKwk9aQIZVUPgrbrAA63S95I A==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="303976947" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="303976947" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:31:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="771691028" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="771691028" Received: from dpdk-dipei.sh.intel.com ([10.67.110.251]) by fmsmga001.fm.intel.com with ESMTP; 19 Oct 2022 02:31:54 -0700 From: Andy Pei To: dev@dpdk.org Cc: chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com, gang.cao@intel.com, maxime.coquelin@redhat.com Subject: [PATCH v9 09/12] vdpa/ifc: improve internal list logic Date: Wed, 19 Oct 2022 16:41:21 +0800 Message-Id: <1666168884-104665-10-git-send-email-andy.pei@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1666168884-104665-1-git-send-email-andy.pei@intel.com> References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666168884-104665-1-git-send-email-andy.pei@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Insert internal list element to internal list before register vdpa device, in order to call vdpa ops during vdpa device registration. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index c16e263..8dfd493 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c @@ -1737,17 +1737,20 @@ struct rte_vdpa_dev_info dev_info[] = { } internal->sw_lm = sw_fallback_lm; + pthread_mutex_lock(&internal_list_lock); + TAILQ_INSERT_TAIL(&internal_list, list, next); + pthread_mutex_unlock(&internal_list_lock); + internal->vdev = rte_vdpa_register_device(&pci_dev->device, dev_info[internal->hw.device_type].ops); if (internal->vdev == NULL) { DRV_LOG(ERR, "failed to register device %s", pci_dev->name); + pthread_mutex_lock(&internal_list_lock); + TAILQ_REMOVE(&internal_list, list, next); + pthread_mutex_unlock(&internal_list_lock); goto error; } - pthread_mutex_lock(&internal_list_lock); - TAILQ_INSERT_TAIL(&internal_list, list, next); - pthread_mutex_unlock(&internal_list_lock); - rte_atomic32_set(&internal->started, 1); update_datapath(internal); -- 1.8.3.1