From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91E0DA0A02; Thu, 20 Oct 2022 04:21:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7D7E40A7D; Thu, 20 Oct 2022 04:21:00 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2120.outbound.protection.outlook.com [40.107.92.120]) by mails.dpdk.org (Postfix) with ESMTP id 7397840A7D for ; Thu, 20 Oct 2022 04:20:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fBXdx04jZjmZ+KDgUKzcPoowUiMLOSyvybJ0K9FWLoC0QBsVfoH2o7mwE0kwla2D7cahVGOrEF9XJsYjauD7D2NmezTOEGpfKBTdbVBbxSuUpspLxioX5CA5vClp1SJld9AUujFyd8RbGFxXwo7p2swJIxg3jScuzeEofPcRM3vZ7AzKyQTu8iiZiUF4lrC3IsfUccUg7szRH9wo7OcaSJDENJhx5rLAuit6fbdZWmkibPrtWCd422TJ5evUDAjg1ytJDQCXbI6VEzNLmBEsnRCPLeRrUIxUjKKwZIj6h8TI1V45k5HAAXCaugp9q74vkLeWq40wT/1h//+gNepkBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YgWMJA8j3P5xwOd710Jfu2GmWNloQrz4joNucpfCGKc=; b=YrJiejccDEEMTNhVOpJd6UYD0fcj0gU7iYVlevg78f/L/+v/Xg39xt0uivVUu5LKE07bUgvaGiUdTYbPefJqem46i2LnUI+KL5JWvEuTob929hGaZdePSyMLNSEGSjie5Eke5AxLVeJQuPGe3u92N5CFxJZTL5Ze9H7hV8SIL8V5EcMarGuzt2foeTl7E62oHIOdWKPw4Gq5YRC+lryhhGfjZFrJqM8JP+SlXKSuBCANqEuxbHAnPNInUiZ7wMfnvKYceYvs/WOGBivKz2qQZplO8p2FCAZ3Bc6E6k53CQcXLq+HA2fvHAPsbAefsvx8mkU0GvVqnXsGNwNqegruOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YgWMJA8j3P5xwOd710Jfu2GmWNloQrz4joNucpfCGKc=; b=jufXwqcW4+vZfRQecsVk8rNWCwgm24R56xSJUhAiyNJUtnEIZCEUWWzZIj5/qhqINJJHyKrjqIxQ0tLh6Jex220KBn0lvrTM/vVxkQ7BgbirUVyi3n06D3CvmlVEhVJbtSe6ispSii65mZmL4nlWDeBLF9KbFcYn3fSYWlbSx3g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM4PR13MB5906.namprd13.prod.outlook.com (2603:10b6:8:4c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.16; Thu, 20 Oct 2022 02:20:56 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7c26:1a0b:2825:6f4b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7c26:1a0b:2825:6f4b%4]) with mapi id 15.20.5723.014; Thu, 20 Oct 2022 02:20:56 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He Subject: [PATCH v5 01/25] net/nfp: fix CPP bridge service requirement Date: Thu, 20 Oct 2022 10:19:27 +0800 Message-Id: <1666232391-29152-2-git-send-email-chaoyong.he@corigine.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1666232391-29152-1-git-send-email-chaoyong.he@corigine.com> References: <1666092434-10357-1-git-send-email-chaoyong.he@corigine.com> <1666232391-29152-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain X-ClientProxiedBy: SI2PR02CA0048.apcprd02.prod.outlook.com (2603:1096:4:196::23) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM4PR13MB5906:EE_ X-MS-Office365-Filtering-Correlation-Id: 36078ddc-a8d3-46f8-16f6-08dab241b7cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KDsIjpumQby5NCZ1JxgMIGkCnvK/p+Xp5VLaRI23Ss8d/z0AZiLQ9ud2DPtxcXyq/MAXIvgHE9uZxDbY8XUet3u0/XmtKQohhf2cfCUCIocFbINJGHL10f8aq9vaTP9u5w+StoAe5Oxs/g1n9X2qQXde5OaeIQZzfVXhVS13NokVCKkBVJPjKuNQIm+qgZdJddYRFyj7onpFlCPOv42hLFDsRneQGEPwqTndkw/Ew4D61Dtn+HUAWsRoe8bjLCIHc/FR9F3/MTdXjXVf+hPA4O7AbsFw/206B87dBIZdmLn2Lw3Fp6AQY14dGS24TsQL/iNmlFLsQxkJRvm7kDb1DVX8/Bpex3ZQwqkAScpp+sk8EgEeodq894ZndhzIeDwvHW0lmiG25F+awDHmxxcgwCO4E5YttjjI5DnfG6AXeqjxd9G7cB7fAaOgDovbrz188i/INh9UByaK71HXhlAW/1jYPsScVxSFK7ZXCvSm6mRJhb4Il6QCpUqObcq6hjEdDPUXE+3oyGjs7HSqNOiQrrOgw+S3J5VTdqk/9Qgjc+3pmEQNm49lkfySXnDFFmo64r9IYWjtfCSxPYCuBSRNwonK/hU8aV5mg0IXhP2Y/ewkXHNiZ+HCUqDte+bcGZVmqvdHvOTPEA06I7IHYIN7AHzs2b+Thlw+UCmKYDnhnJ7G3Cn6qPVxDV/Rr0IYGyU6Ato8rkvL4HwNFL3V9OrO9uOhcQpJEZxhWO1GWpM6rj8t175lKcsOq3SI2BQ58h0AWGUHNEbtMx0tH08C8AXQ1Lh6QaElf/8jJyezgkaPil+swyucFPwrJBPZrZ4QF7+q X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(39840400004)(346002)(396003)(366004)(451199015)(38100700002)(478600001)(38350700002)(316002)(6916009)(2906002)(186003)(66476007)(52116002)(66556008)(6666004)(66946007)(107886003)(4326008)(6506007)(2616005)(41300700001)(5660300002)(36756003)(8676002)(6486002)(8936002)(26005)(44832011)(86362001)(83380400001)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CgoY2ENU5UTmHabJAQZf7a6S/Dw/6o5ivCPPew2DC7Gyp8NF49DUnFWKbqfQ?= =?us-ascii?Q?aI01tsRebTS8RR7itVhCN8W6KWZk+FoMZQAyydGre6bqRvSCikiliLx+joNL?= =?us-ascii?Q?F2N3tGeHLLjXP9YRLyBGihT5bomz9YsAkMoqtVZGIUMuxFu3lMM+ct4ZvC+2?= =?us-ascii?Q?NbBPeS0fJj1NrEfhMKUtXS8E6Qr09GWhXb3tM70vDaEipnWdydNejVu2kRBP?= =?us-ascii?Q?gb4mHZ3F0Hq23912z1Sup0f1ePdxIeZuwKINBNPj6xf3gBHMacmddakdaQLx?= =?us-ascii?Q?/6KslC13yNe4+tVHLhtaVGovgBcX+bP+X3Cx1oGDzmL+3uBfypiF05mcNvl2?= =?us-ascii?Q?R0L+HKmqdJEPJChKO5f1B2Petd+19DiJKBv/tvIuaN+j2ro5DmGm7OzSHObj?= =?us-ascii?Q?7LdP2HZ6vDg0WNdQcv0/3PJ6NGIbzdPPu8Zmwl3pcSgQAUy9XxEYJIsbFhgo?= =?us-ascii?Q?ABLfmzQwcJICKipHeuqpjk78t7UrOoEM8Reeck3YwYvrzLtYNuEOGXc1JlRp?= =?us-ascii?Q?swAkHORwQAE/uwZUC1nG7ejWwV/qm13bOI2ylrAszCu/NvRPHkeuGbCUGSib?= =?us-ascii?Q?tt5FQWmnyI1FAZExuUURpPRKb3UIPsAxOcqbBaygYYvkZ5UPi0EnQoZoVzQn?= =?us-ascii?Q?3oEyNCp/Xejf4Eclx7gv3mKEPMUE1veR/5QyfKwinzHwW5a9dDppRjr5m4/h?= =?us-ascii?Q?mnVZAhUUnN4JetPFlL8crHSTQlN9HR2aP+BSceB8iyyIQBhaMKP8/aKeF08K?= =?us-ascii?Q?nPj4k+284YS07++pHh2v49CdTcjxDG7PWNlDwwSyw2FGVMY8D19ctzC66HAK?= =?us-ascii?Q?TAbpgvWfyW3mxvtyUqQQ+9IMlo1Kku7TX2LCZ9GpD6n5B2+cUWhU+icAc0bF?= =?us-ascii?Q?bH6DXuJV5fzUSuGbJceRHnzUDzNJQ3BxciTlY1r4lsqmpG4fMXtc9kbRc5Zl?= =?us-ascii?Q?DGK0X6ZVMb72opf6IYUYNcAE2cWLlav20t7E7cIk9mCI+LVn7s3zKbD4qC9g?= =?us-ascii?Q?UQEr2Re1uSHbfmva7U2sJPzzQ+ZnqiQ2qWpsL/tPPtvTGbRQ4VZriDj185yg?= =?us-ascii?Q?M0qNagcB9+gEwFSemJf4+cSKF8z9g4fwzb7+UcouF9+wz1mCmNSC5SgeLdnJ?= =?us-ascii?Q?tPoVBnvHZuxSD4jcbhoRavQSbNh7lTW92CX5u60IwaJitJ/veDuG/W5mSnYj?= =?us-ascii?Q?yzYRU3BcjvmC37ICSpDU8D117HPw/GlQeUZydQWjo0/ClH0ks8gyCK7YZ9jU?= =?us-ascii?Q?dqd3prWvwHeL2MdxhiOKmJf1/Fy4iRHg7AWwFBAxUsUaGJVyA1dWqe4kn0/+?= =?us-ascii?Q?wDEb6qyPl6Gzn8J5+Lrh+iIdLQfLHueFEx4t/2ar7tWn94QMSsq80uiqKpZJ?= =?us-ascii?Q?GWU4ME+Y9wNn/DIMperL63zh7/qvwqelGpyoitmpwzPfdIMKqPEapdea5QNO?= =?us-ascii?Q?eNFGZIjGUBBiSSqFxIZ2Vr7azfM/CKsYRluuRmyo0FkabvE9eYKSzuNzN1hC?= =?us-ascii?Q?pz2FCvK+0vgAJ4N24AwCWVgLnseORCxbB0i4EpRLcTZhuE7qwiCBQUmljWu2?= =?us-ascii?Q?OQYVaAjP7waZkyebz+GldGTTNO2InWmfXNX2LmtPiAv/eWyt2oWRdrd0irI9?= =?us-ascii?Q?2w=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36078ddc-a8d3-46f8-16f6-08dab241b7cd X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 02:20:56.2165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n+leseVQwCoaTXH7sXIV0RaxRJqeHdv+udddblbbuVm5R5jPTB4yZ+NHvcbYM8TezjhfIB7HhAW+Txwtx95GeWXBOSW4XfVR6MDgr2QjXS4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR13MB5906 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The CPP(Command Pull Push) bridge service is needed for some debug tools, and should be optional, so remove the mandatory requirement of service lcore parameter. Fixes: b18804219537 ("net/nfp: add initial flower firmware support") Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index f11a1b6..78c5c0f 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -1066,11 +1066,8 @@ /* register the CPP bridge service here for primary use */ ret = nfp_enable_cpp_service(pf_dev->cpp); - if (ret != 0) { - PMD_INIT_LOG(ERR, "Enable cpp service failed."); - ret = -EINVAL; - goto hwqueues_cleanup; - } + if (ret != 0) + PMD_INIT_LOG(INFO, "Enable cpp service failed."); return 0; @@ -1210,10 +1207,8 @@ /* Register the CPP bridge service for the secondary too */ ret = nfp_enable_cpp_service(cpp); - if (ret != 0) { - PMD_INIT_LOG(ERR, "Enable cpp service failed."); - ret = -EINVAL; - } + if (ret != 0) + PMD_INIT_LOG(INFO, "Enable cpp service failed."); sym_tbl_cleanup: free(sym_tbl); -- 1.8.3.1