From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89A62A0032; Fri, 21 Oct 2022 10:02:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD1ED42BB6; Fri, 21 Oct 2022 10:02:26 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2104.outbound.protection.outlook.com [40.107.94.104]) by mails.dpdk.org (Postfix) with ESMTP id 20D0942BB6 for ; Fri, 21 Oct 2022 10:02:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uaa1wsrhcQsBcSvPXCMjKeYHnFXOe4SWg0YQFjH4/xJqq76TAHzrl0+Mo1iFY54qcQfoGWKFPlaJEyRD98aKJAtOG5G7PBH1EwHXcDQVGTWWSR1rOtIhyS8Cv+J7J5t+axTehrBTqpYm5Sr6OXi8DGbch64rsTANVxjgw80NPwR/T7aTgldfg/hTVjBjb+2c7jqsHWmVW2bwCU+CWcIdAt5nR8OTH4ppf2+uf/eE2nO3qomB7e+YQhcFE9GCf7vido1hBZpv/7l7R2pPzot3J9noBEhuAH2wQ6s813dHvX72x1J0u3numYyutvhPhicKstMYWjYUtbHKq/dcHDb5Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W9eumaKcKZ/KfJTAWEYQ4OxgMqXnHX4XLfi3wLLrmTI=; b=eA/fcm3Q6cy71TuXR0dhL1ImiAIoUp/RjiGmOeBFc4kmYmEKq7Qd8FPKkf1hwKKkugdmvJwsiApBbNc2jVx73LpEOds6L2dR7NxNKMoBxWpIl6gpe2L85aAByQC1PJf2yZHeFdpP/TjBqn2QiBPkSbxJ2ccLd0ecfOG6klj4RH2waYARZSTKUBfzJuBZtm7EeI8Ssn4XTe2OURtf5XWVj7nzKZ3KLNVKvKibJ9QCrctuGYeHqAXz6njjq8djqk5Pgm9gTuWzSwobGwCxI5AtRe1vyiOcg4rjvq4RlKCxj0njo4cxWCeX1jnp9LrtufRpoRB/d5b0TGHZeFasbrz+rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W9eumaKcKZ/KfJTAWEYQ4OxgMqXnHX4XLfi3wLLrmTI=; b=LtzDdQ2ntkpaL9CTiNF/V1TSwBOcR+n4sq4H/m8m7RevCGUDAtol3Dl5ZiAKwnYLkJnBHffp2dkUR9qpJWuf9O5WbqYT9sPoXpObGo+yjCWCSH41KbUgPPjXscK7P35+FTawJFGOkvpSFx7/3yWfvMHk0Q+PNOaYbpm1sKdkjOY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM6PR13MB4493.namprd13.prod.outlook.com (2603:10b6:5:1b9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Fri, 21 Oct 2022 08:02:23 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7c26:1a0b:2825:6f4b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7c26:1a0b:2825:6f4b%4]) with mapi id 15.20.5723.014; Fri, 21 Oct 2022 08:02:23 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He Subject: [PATCH v6 01/27] net/nfp: fix CPP bridge service requirement Date: Fri, 21 Oct 2022 16:01:37 +0800 Message-Id: <1666339323-24016-2-git-send-email-chaoyong.he@corigine.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1666339323-24016-1-git-send-email-chaoyong.he@corigine.com> References: <1666232391-29152-1-git-send-email-chaoyong.he@corigine.com> <1666339323-24016-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain X-ClientProxiedBy: SI2PR01CA0051.apcprd01.prod.exchangelabs.com (2603:1096:4:193::6) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DM6PR13MB4493:EE_ X-MS-Office365-Filtering-Correlation-Id: 08a4cbd2-f7b2-4199-9d2c-08dab33a9614 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8X/E7ELp7EYOOZmaNsSW6XsWuk2d2VRlkx303krVGKiq0qon98LP3TstXSvdvSboF+3m+iCKOcXwKU3y8sIBbIoDVeagGpFFPXTLzJqM43W55S8uWlEBmazbxFMvyrVlSz7wE5/oNTj9Q2w5syeusOGk2+cEmKZ87+GCC/mk6MVbkaQOelWtdxgZPpEtRIgfjb2IpsPd2rIdeut8MPQ4lDGtdhHAAoSqeufcvl+9og2nNAL6mWL7aL0j0WxjSc1VgTHR4cNY90iqfe2G4BXbRO9KWp+8FX+A/NGvf44mdKj+5e8J7pp92XppEr9jGslR3w1BwASlYvnHh5oOf2uzXyGAuWQ4+DRcDGiDzl+Ofaa000h6/JSIEQ+OaA97wuH8Ykdbbob9lwZrF3uxrfd3Tpxo7sScJQ/632zUO7pgf17aGi9mFR1NJAcIH5rim18SFFCDf8XRjdfNZl2slLJ9abVqkVyx15CtH/VX21BwIKKXKbjyKyPnaWaMY3U72UPi2kDXE9Wumu7Dls2TE2PiLPNUahf2FhonwQ3aV8fhDIfePqT2XNzklgMb3WSFXX13ZkndFlXJot+KTTzhF20bOddUgE9M8vPYQWjCMbXJcQbw+pYYpsX7mpcdzw3Sk8GA6Nks7mHWj4Sqh7Eh9D2pUx4fb1SA/IrbjXMJRZD21JouKMOmP19Wa62W6XiDsHfMbWtHtjip2NCx/D1vi74W/Y9Pmgzadw07hmvuFYZbX2HI0w2+qwfZ+nxmmX3PKrEC5J/O9eOQpx48uJ2t/6e1iA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(366004)(136003)(396003)(376002)(39830400003)(451199015)(36756003)(8936002)(66556008)(86362001)(41300700001)(478600001)(83380400001)(2906002)(5660300002)(186003)(6916009)(38350700002)(2616005)(4326008)(6512007)(66476007)(52116002)(66946007)(316002)(8676002)(6666004)(6506007)(26005)(107886003)(38100700002)(6486002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xBk8HOT5ymx5skmpWvRL6DRX3xit/FZFjEdfZ0wdpTT/zOY9kxDVy5Y6Gv4m?= =?us-ascii?Q?H/1QhUIHiDa1+IKzZI6gQo5Dk/hZylwMV9rdsLZnW4O8ZxPoltRVTWbRkO6K?= =?us-ascii?Q?QoR7nDKtIxQu4Wq8/HqSja+wX9ZaREQC/vTp18K1Y063A+7xVRB0JpCS1QjG?= =?us-ascii?Q?KH+uCtpMNFwOnioOQbCIRXcLO4P4nyonuynD6zXRghRwkD8aSrMq2U3jvNj5?= =?us-ascii?Q?P6xGgaq/62ISHG7CZvk5AP+jD9H7nHn3E0Bu3GuwxiMLHoGlYs1Gx6MkGbE3?= =?us-ascii?Q?mSZZaAVBsTPKxawzozphFAAY23hPL5k0s3Lyimf9rhDGdA6LuNJ/IZgHrs8l?= =?us-ascii?Q?55BI6BdLswK1UP6odPDpH+GNuFAQyaH/mAUtbELcRLeEjZ+RPcjSAicH1/Cy?= =?us-ascii?Q?Gg7KZt2L/5Z+aWElOPbETMoTvkP9roRtzjxRlv86YEqJft8zHC0ELilB9NeX?= =?us-ascii?Q?5tbC/7J1ySHLM7PCa3oEWno9junl2MT7nJQRB9f+DDMpz+FKxijCNKZNE/Fm?= =?us-ascii?Q?o/YhyDpq++7htqoTcq625/+fLTTK6Wp27Yq9kv9CQcPTfv7eVhLj/YVK435c?= =?us-ascii?Q?mFhiGTA5zLnv3PUCCpiDiZ/kmCE7BpboKaXHu0oKNNdGdLcTnC4VegXacQ4W?= =?us-ascii?Q?/ZDjU/x59957hVEcQ2Sni8BeV/E0iNK5aRW1MVmAOcse8jHGKze5zHzANq2j?= =?us-ascii?Q?BJmpNqM2nLPwWnyVZV2SVCXtLCj1UeNPFKm5ECYj6a69XsDTsNEIRQYjnLop?= =?us-ascii?Q?xGgawqCI3pjiWlk0BfPOT1QSrg08d9+7eIBRIr+Xg+ApOQpgDULznnSJCnDC?= =?us-ascii?Q?hWKBrcTd7e6QNceYPgy+s80dkvqlqfyekO7wUAZOuhzBFaSYElWbe6AymNKn?= =?us-ascii?Q?tS49ha+iji55itSeW3RwTrALXhI32ggzIoJHlVMWO9gnBxmacagpdCkjxxQS?= =?us-ascii?Q?xRqjAWyKis373dHnOUSZk7HpzXC6hxTVr2TmiKdQqdiFVKbtUtfKCUkW9+yx?= =?us-ascii?Q?AG3t+ZGGZ5tobOb/rgXzZFKrQdQsVtuFbULrse6XpYmgDI0kE5fveV8Qkxan?= =?us-ascii?Q?U9xdYCoQu/SxgCw7pB7cHMs7U81Ei4Bk3KNaN33o5++4P9InbdeNz6O8O4wI?= =?us-ascii?Q?6qPWhXgamMYu2EtDGIG1dvlOnIbG682hn4nFiGMKu217/tFGZv3iyCsYHV5N?= =?us-ascii?Q?CDT75oXNwjF7koaS0kKnPLaPAkSwiF83r3clFmhNhV8iGDfdMr/p/l/7ADA/?= =?us-ascii?Q?vhJ1v4+VkL9nWWVT4jIahSOpt0mE4ec8nFcJaWMLntcJfSsty8QFCccWij5T?= =?us-ascii?Q?G4kJMuDUliujCVIAi/K0N8aKKpawJkhcqiWOM67WouVF359t7jQVcbAzEeCK?= =?us-ascii?Q?DHXucybg4NNzglLsBEuUOM7pRPboAKoyGSdL4Z9iB23IBcoI21CG6jWNAio1?= =?us-ascii?Q?SABhbzHdaqzqukArxRZCH5Jy/HDUwAlr5gfdd9jxJnJPag30MvX5vAjkPAcm?= =?us-ascii?Q?6Xcgrlt6qFsixeQPBgaWm2zy6LPdg49qmJhRR1ZZG2QGdhTB2mQfcqwQeqcO?= =?us-ascii?Q?jCY6vuQdZ2AwKDRAhF/5XltXWi8oHaNphX2G0V9aD14vet359+x8ouBlSJj8?= =?us-ascii?Q?Wg=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08a4cbd2-f7b2-4199-9d2c-08dab33a9614 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 08:02:23.5160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: thgmxB5lxNh2qvva2tX3kVu2rSltYRxmSrQZBTkZ7JuMeHMTl1V5wP7xFwnAaveVlIO29KHFo8NRiRevgsVWjDPEAGFNGRPwldq3LarlnTk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4493 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The CPP(Command Pull Push) bridge service is needed for some debug tools, and should be optional, so remove the mandatory requirement of service lcore parameter. Fixes: b18804219537 ("net/nfp: add initial flower firmware support") Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index f11a1b6..f25d6a1 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -1066,11 +1066,8 @@ /* register the CPP bridge service here for primary use */ ret = nfp_enable_cpp_service(pf_dev->cpp); - if (ret != 0) { - PMD_INIT_LOG(ERR, "Enable cpp service failed."); - ret = -EINVAL; - goto hwqueues_cleanup; - } + if (ret != 0) + PMD_INIT_LOG(INFO, "Enable cpp service failed."); return 0; @@ -1208,13 +1205,6 @@ goto sym_tbl_cleanup; } - /* Register the CPP bridge service for the secondary too */ - ret = nfp_enable_cpp_service(cpp); - if (ret != 0) { - PMD_INIT_LOG(ERR, "Enable cpp service failed."); - ret = -EINVAL; - } - sym_tbl_cleanup: free(sym_tbl); -- 1.8.3.1