From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 089DFA0524; Tue, 13 Apr 2021 11:01:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F912160CFD; Tue, 13 Apr 2021 11:01:38 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 7EEAA160CE7; Tue, 13 Apr 2021 11:01:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id D354E5803F0; Tue, 13 Apr 2021 05:01:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 13 Apr 2021 05:01:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= XR240MCquW2aJRG8TtJRsM+RzT6jpso9QrLNGsa7bXM=; b=rKf4Lc9XHZBdCfsk vOM5Q6HBMR/0ZVO/w1iWSBEfqXdR3mxE1yz58FMW1tcr4dKqhgYvbqM6yOgymdDj fTAXnNpKOMZd3WKxZWWh9l4KVUO8UyT/Zb7Z0X9BO2ddV9y/4K+e7BRsxA49yEQ9 qaerh7ErvBPnfDWDPWYxqPrkhm+rCEqRfUQpzFtQs2NSAuRtzMVvoqOGm7YB6z+6 LGMUfjwQces9NJxO2JhXX+NU/zJeOorV/5nEDG0L9nPCTb2nxRPKKXb2I6QV0Gte pXGzc/Luep51WYLA1zULNeUiQWjIiBF5qaQNSv9BdXKnOrtf71JZOnzk51jQcu/U 2i12+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=XR240MCquW2aJRG8TtJRsM+RzT6jpso9QrLNGsa7b XM=; b=MCwlp6pL1EGrl3bMLen8KRUD1WkT1v4iCWyCIEGwV6d8j6F2dfdII9RC+ i4ekZ1/HBGkzA8c6xtnGUXQOLPHeNDVCc1XhZaJNq8C28selNVmxFyUt2fN1rvdX JinRcs+/KWvRIFuRyDfT5Z4LD1v7Lxk7IEVRflAtEczKJ/Dx7Ze5VxZq0KZNdtWH hQ6pi3V4ycA24Pt4J071PhQeNWQIRAuVjkZJOM1RfJDm/iJcASGbo7y4exTzHKKu 07nrxblJjRKCSu7af0mLoq1e7SGV0gdDoFAXytCtI3g4rXvi2qf+nKHnFwlHlj24 VD+pzv9gASFFbFuquY1MjipmDAZEg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2EA7324005B; Tue, 13 Apr 2021 05:01:34 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: David Marchand , Timothy McDaniel , Jerin Jacob Kollanukkaran , Ray Kinsella , Aaron Conole , dpdklab , "abhinandan.gujjar@intel.com" , "harry.van.haaren@intel.com" , dev , Shijith Thotton , Akhil Goyal , Pavan Nikhilesh Bhagavatula , "mattias.ronnblom@ericsson.com" , ci@dpdk.org Date: Tue, 13 Apr 2021 11:01:33 +0200 Message-ID: <1669547.TGag7vyBUX@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/04/2021 10:54, Jerin Jacob: > On Tue, Apr 13, 2021 at 12:46 PM David Marchand > wrote: > > > > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon wrote: > > > > > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran: > > > > http://dpdk.org/git/next/dpdk-next-eventdev > > > > > > Pulled, thanks. > > > > > > Note few changes in titles like uppercases for acronyms, > > > or "add support" simplified as "support", > > > and release notes moved in the right place. > > > > The ABI check now reports an error on event/dlb. > > The reason is that the event/dlb driver has been removed, and so the > > check complains about a missing dump. > > This will have to be fixed quickly or reverted. > > > > > > This has been missed by multiple people, so trying to understand why. > > > I was running the following script[1] to detect ABI issues. > Since the "./devtools/test-meson-builds.sh" did not return non zero value or > the error print was "Error: cannot find librte_event_dlb.dump", It is > missed from my side. > > @David Marchand @Thomas Monjalon Could you share the snippet you are > using for detecting the ABI issue. I do like you: simply run test-meson-builds.sh And yes I saw the error, and I don't know why I thought it was OK! We are humans :) > ------------------------ > # ABI check > DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash > ./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log > if [ $? -ne 0 ]; then > echo "ABI check failed" > exit > fi > > grep "Error: ABI issue reported" /tmp/build.log > if [ $? -eq 0 ]; then > echo "ABI issue" > exit > fi > > ------------------------------------------------------- > > > > The ABI check should have caught this when run by maintainers (/me > > looks at Thomas and Jerin). > > Sorry for that :-(