From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id F1E8711A2 for ; Tue, 15 Dec 2015 18:08:46 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id l126so3571589wml.1 for ; Tue, 15 Dec 2015 09:08:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=iddWeAxukfugj+LCWx2zObz/RNrrDL2mUh7dZFVzsAs=; b=Bndez1l8CcB1giyLPWyRyv9wRzuyntzpjE56zLWJbCV0gC69geUMe2tfirDSaTGyvJ 1F9o13v8ZTh5QJplZ3tBLAKiqu+YXlDNV9w5JGwl7zIUkqYsLziMLHOWPcVWaQFu4C7W bfO9E4AaaW3Qfqa51NK3To66MCiPGzoo+YfUVER4D9RtCyxdV0usewYHLeIf9CHEitqX zMDl0jzJW+DnqSRzyiYdCDukFWPMMnQO9gJsHinovwkcLIA6nvKeUIWQoegKtZXOObKZ VL7uq7wfQvkSgviCxKKvSpVAZCfKqOEx3ArHuxrrHW+wRXRU8fV6dXDAE/QvJxqwlDRZ kmWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=iddWeAxukfugj+LCWx2zObz/RNrrDL2mUh7dZFVzsAs=; b=HfQrRfC7ws0wBEIoogGebiIk3pIXVxFwvyOoGUkLEuSBHLhBmOhSYF63cfSV9tSaAE IJawkBi76tjh1SJ3+7Tck0Psj9FTQnNaPm0lyS9rdYrEKbNm1F+EQSpPyT3jJ1mjPqud dY4VeR4a6s5bp+SnZIG7/hGuVPCIkwV4/c/4wYaXcwJkp7JojB3YE5hEklc83/f5GKmA x69MNS9VBbB3lYUW8upCAFTaWmbdwZ21pdrgZ1HiUy95N9Vh7jzO0aEiPkEFdNe/e0iG IhQW/vSAx+xmaOFN6gb/KxWf0if9zqewCxeO3zGCp0LyAzOgmd37Z5HX9ljCTmaTC9eE s7Tg== X-Gm-Message-State: ALoCoQnqbZvE6odPbaF861s/PeGm+vLv6KE7+00q/lo/ZoLsfI5DhnHexosj5J4To5PJdm7gNLesREWjo7z8Rhq+689RQzu1Wg== X-Received: by 10.194.236.38 with SMTP id ur6mr45674177wjc.13.1450199326869; Tue, 15 Dec 2015 09:08:46 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id b84sm3637243wmh.15.2015.12.15.09.08.46 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 Dec 2015 09:08:46 -0800 (PST) From: Thomas Monjalon To: "Wu, Jingjing" Date: Tue, 15 Dec 2015 18:07:30 +0100 Message-ID: <1671518.qOKSgfYHRV@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1450196587-23248-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fix unintended sign extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 17:08:47 -0000 > Coverity issue reported like > > CID 119268 (#1 of 1): Unintended sign extension > > (SIGN_EXTENSION)sign_extension: Suspicious implicit sign extension: > > vsi_id with type unsigned short (16 bits, unsigned) is promoted in vsi_id > > << 23 to type int (32 bits, signed), then sign-extended to type unsigned > > long (64 bits, unsigned). If vsi_id << 23 is greater than 0x7FFFFFFF, the > > upper bits of the result will all be 1. > > > > Fixes: 88ebc2b7f976 ("i40e: extend flow director to support VF") > > Signed-off-by: Jingjing Wu > > Acked-by: John McNamara Applied, thanks