From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 01CEF7CDE for ; Fri, 22 Sep 2017 12:42:35 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8171820E69; Fri, 22 Sep 2017 06:42:34 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 22 Sep 2017 06:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Jb+N7ytm4sIBcNS XTi8JYErsODZOZP8yM/DQuG3XS44=; b=qKOSnhNzyQ6qULjkkwcpJsj5tRP7n+6 1fpJAeDMa39h/ZCMLU3ruCxOApuxgkrPFjv47LX2De4mDkY3TtmtNSmO4z3S06Oq clshXR3KlGWZsPb3XYz5hpxDJ8K1EemK64cskr4dY2y7joxEUTegswyD3UaTkofo r8LRPfwxeCxc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Jb+N7ytm4sIBcNSXTi8JYErsODZOZP8yM/DQuG3XS44=; b=Z44PUbVQ RM/6aUcej9Q6YMRVfJ7CCx3FuypieKWauX+AEbrhFuIis4rniKv+CinBg+upd8ty vHSWvFgpPlyg7CYEzH7Mun1bVzXbXdQIU5jKTBbv2yhKui+VrTshO4y9X26Wl+Ga 1STx34gJFXxrdaL0G/EpKvnBIJ0dGhT8nrmXUM9nkSUmjVWVWfjca5WUocgKYpim /+FS4djvXQyC3j9u9Xuw7Zxf+sKjyulCylE4Ag8Zzat77ur6Qa//OvcdYDafzi6l X24ZGaMtKO4/Zi/oZkePhbGqLL8DWfgbps5yYrHCt+LVdFw+TAXC4lV2oV6SqLgT OiV+IVM5JWVnHw== X-ME-Sender: X-Sasl-enc: Y3AlWoJ56ApPlAlXe2yOhuzIshN6GTwwVR8KGz67l2/j 1506076954 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C3AE24515; Fri, 22 Sep 2017 06:42:34 -0400 (EDT) From: Thomas Monjalon To: ilia.kurakin@intel.com Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, keith.wiles@intel.com, dmitry.galanov@intel.com Date: Fri, 22 Sep 2017 12:42:33 +0200 Message-ID: <1671807.t1LnDJUZi1@xps> In-Reply-To: <20170908125721.2878-1-ilia.kurakin@intel.com> References: <1500915997-26223-1-git-send-email-ilia.kurakin@intel.com> <20170908125721.2878-1-ilia.kurakin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7] ether: add support for vtune task tracing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 10:42:36 -0000 08/09/2017 14:57, ilia.kurakin@intel.com: > + /* See rte_ethdev_profile.h to find comments on code below. */ > + __rte_eth_profile_rx_init(port_id, dev); We can find easily where the function is defined. Please replace this comment by something like that: /* Initialize Rx profiling if enabled at compilation time. */ Why not checking an error code for this initialization? If we enable it, we expect the application to abort if the profiling does not work. > --- /dev/null > +++ b/lib/librte_ether/rte_ethdev_profile.h This file is internal so it should not appear in doxygen index. Please remove rte_ prefix from the filename to blacklist it from doxygen point of view. You can apply the same change to the .c file for consistency.