From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 9CC8BB377 for ; Wed, 27 Aug 2014 16:54:47 +0200 (CEST) Received: by mail-we0-f173.google.com with SMTP id q58so360618wes.32 for ; Wed, 27 Aug 2014 07:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=lAq6lDfy2qK/UHX8vsmfRVOOnyf596f/ex58tLp4Q2w=; b=a95SaS3rgra1l9TEz1Sm8k6xdi+kZFV2gjvjPY9onCpYACOfFMmrwTUQSPUYvDxgUJ 5tPrKpaOegQnYHKZscjo0C8jJcMr4H+0+7AC7k3y9YCFRs24j4cxVAAnufvnNdqTSmS2 986Kz9B7eq1Iq/gq442eu2k9URoahE89NwVROvztInGdDplevj8urP9CrRf0RTaumwYE kcADaFgFV3fyoJplXaa0jwZqQ3T3IpeB0XvF9VMtylPE5XOCsZiuboA9TQTIP17thrp8 vs+6VMs3EAzHUp8BnsFEkQM98svbOM0Rrsgmrcz3dlX5TNerbGOLSk/6QDull5dhOVgk /H2g== X-Gm-Message-State: ALoCoQnpC0Ey8xHqTsz/5sC97P3FHxyjcTxk14tNYfX/jlfWhIofr1V2AL5DSt+LECZclv86cs89 X-Received: by 10.180.20.142 with SMTP id n14mr14418495wie.22.1409151531422; Wed, 27 Aug 2014 07:58:51 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id ju1sm1773620wjc.1.2014.08.27.07.58.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Aug 2014 07:58:50 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Wed, 27 Aug 2014 16:58:46 +0200 Message-ID: <1672259.DZkGQ2cZmA@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1409038294-21693-2-git-send-email-jijiang.liu@intel.com> References: <1409038294-21693-1-git-send-email-jijiang.liu@intel.com> <1409038294-21693-2-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet identification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 14:54:48 -0000 Hi Jijiang, 2014-08-26 15:31, Jijiang Liu: > VxLAN UDP port configuration on i40e, which include > - VxLAN UDP port initialization > - add APIs to configure VxLAN UDP port Actually you should explain that you introduce tunnels and first one is VxLAN. > lib/librte_ether/rte_ethdev.c | 63 ++++++++++++ > lib/librte_ether/rte_ethdev.h | 76 ++++++++++++++ > lib/librte_ether/rte_ether.h | 10 ++ > lib/librte_pmd_i40e/i40e_ethdev.c | 199 ++++++++++++++++++++++++++++++++++++- > lib/librte_pmd_i40e/i40e_ethdev.h | 5 + Changing ethdev API is so sensible that it deserves a separated commit. Code seems OK. Thanks -- Thomas