From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 25D0BC39C for ; Mon, 3 Aug 2015 19:21:05 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so131152534wib.0 for ; Mon, 03 Aug 2015 10:21:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=CqC8O9b+V18Yl1NfJufYekNfwitcGNBIzbKL6OO7Hhc=; b=TtKYSI7wziamW//O2Zf1RF96wHPzVJcuEzUhT41UNtEBrRJ3KHMfwMV7GJRgLcQfbJ xxNw6nfB9Io9f95fjtOCE6g+/Ow0PGjUxFZo03y8u+xBhPEgYfv0ZOIhSoDmbQ3zbBcp uPWi4p6oyr1EzXC1cA9IGiEfz7bda65hqJBGw+ulPFBf0tHmmRN9v4bZv379ooSdT4mh Skad0IzhB4KpOFTjuEacYWzBncpLlojS+7nbWu5QWj0O4u5hWuMmvx8IBs5afPluMixw d+Z+Do1usc8tUJqd98wTKEtqRgSZfet6jf3gHTsB3D9lq5TnTw9bKc9tx6MntwvzBZx8 sAXw== X-Gm-Message-State: ALoCoQkm+dgxRQFa2gO5PQ5imre+69CcHP1+tvMrExYdWx3O1PpFM2h/oadFQCx8gjhIioWor3OE X-Received: by 10.181.25.234 with SMTP id it10mr35100450wid.41.1438622465017; Mon, 03 Aug 2015 10:21:05 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id gw7sm14557849wib.15.2015.08.03.10.21.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 10:21:04 -0700 (PDT) From: Thomas Monjalon To: Matthew Hall , "Liang, Cunming" Date: Mon, 03 Aug 2015 19:19:46 +0200 Message-ID: <1673557.cjtS5G2rXq@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150803050441.GA8325@mhcomputing.net> References: <55BEC80E.5010309@intel.com> <20150803050441.GA8325@mhcomputing.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix negative value for undetermined numa_node X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 17:21:05 -0000 2015-08-02 22:04, Matthew Hall: > On Mon, Aug 03, 2015 at 09:46:54AM +0800, Liang, Cunming wrote: > > According to the API definition, if the socket could not be determined, a > > default of zero will take. > > The '-1' is returned when the port_id value is out of range. > > Yes, but when I asked the exact same question and was told the documentation > was wrong not the -1 return value. It was an error. The correct API, as defined, is to return 0 when there is no NUMA. This patch now reverts this one: http://dpdk.org/browse/dpdk/commit/?id=a4ff75496a18 Thanks Matthew for helping to clarify it. > Sure, if nobody objects like the last time I asked. But this will change the > user behavior as I am looking for the -1 now. You're right. But this fix follows the defined API, so it's rather an API fix than an API break. Applied, thanks