From: Vipin P R <vipinp@vmware.com>
To: anatoly.burakov@intel.com
Cc: dev@dpdk.org, Vipin P R <vipinp@vmware.com>, stable@dpdk.org
Subject: [PATCH] Memory Allocation: Adding a new UT for fb_array
Date: Fri, 13 Jan 2023 13:12:47 +0000 [thread overview]
Message-ID: <1673615567-20873-2-git-send-email-vipinp@vmware.com> (raw)
In-Reply-To: <1673615567-20873-1-git-send-email-vipinp@vmware.com>
add test case coverage to cover the ms_idx jump
Cc: stable@dpdk.org
Signed-off-by: Vipin P R <vipinp@vmware.com>
Acked-by: Kumara Parameshwaran <kparameshwar@vmware.com>
---
Depends-on: 0001-Memory-Allocation-Fixes-ms_idx-jump-lookahead-during.patch
Depends-on: 0002-Memory-Allocation-Fixes-ms_idx-jump-lookbehind-durin.patch
---
app/test/test_fbarray.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/app/test/test_fbarray.c b/app/test/test_fbarray.c
index a691bf4..275449c 100644
--- a/app/test/test_fbarray.c
+++ b/app/test/test_fbarray.c
@@ -11,6 +11,7 @@
#include <rte_debug.h>
#include <rte_errno.h>
#include <rte_fbarray.h>
+#include <rte_memory.h>
#include "test.h"
@@ -402,6 +403,53 @@ static int check_used_one(void)
return 0;
}
+/* the following test case verifies that the jump in ms_idx for an fb-array is correct. */
+static int test_jump(void)
+{
+ struct rte_fbarray test_array;
+ int input[] = {1, 1070, 1, 2, 1, 2, 4, 12, 2, 2, 1, 2, 1};
+ int ms_idx, prev_ms_idx, delta;
+ int len;
+ ms_idx = prev_ms_idx = 0;
+
+ int ret = rte_fbarray_init(&test_array, "test", 32768, sizeof(struct rte_memseg));
+ if (ret == 0) {
+ RTE_LOG(DEBUG, EAL, "FB array init success\n");
+ int k = 0;
+ for(int i=0; i < sizeof(input)/sizeof(int); i++) {
+ if (i == 0) {
+ len = input[i];
+ } else {
+ len = input[i] + 1;
+ }
+ prev_ms_idx = ms_idx;
+ ms_idx = rte_fbarray_find_next_n_free(&test_array, k, len);
+
+ if (i != 0) {
+ ms_idx++;
+ }
+
+ for (int j=0; j < input[i]; j++) {
+ RTE_LOG(DEBUG, EAL, "ms_idx:%d\n", ms_idx);
+ rte_fbarray_set_used(&test_array, ms_idx);
+ ms_idx++;
+ }
+
+ if (prev_ms_idx) {
+ /* The value of ms_idx should be monotonically increasing
+ * given the above input sequence in test_array.
+ * */
+ delta = ms_idx - prev_ms_idx;
+ if (!(delta > 0)) {
+ RTE_LOG(ERR, EAL, "ms_idx jumping behind. ms_idx: %d prev_ms_idx: %d\n", ms_idx - 1, prev_ms_idx - 1);
+ TEST_ASSERT(0, "Incorrect ms_idx jump");
+ }
+ }
+ }
+ }
+ return 0;
+}
+
static int test_basic(void)
{
const int idx = 0;
@@ -717,6 +765,7 @@ static struct unit_test_suite fbarray_test_suite = {
.unit_test_cases = {
TEST_CASE(test_invalid),
TEST_CASE(test_basic),
+ TEST_CASE(test_jump),
TEST_CASE_ST(first_msk_test_setup, reset_array, test_find),
TEST_CASE_ST(cross_msk_test_setup, reset_array, test_find),
TEST_CASE_ST(multi_msk_test_setup, reset_array, test_find),
--
2.7.4
next prev parent reply other threads:[~2023-01-15 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 13:12 [PATCH] *** Memory Allocation: Adding a new UT for fb_array *** Vipin P R
2023-01-13 13:12 ` Vipin P R [this message]
2023-01-16 17:54 ` [PATCH] Memory Allocation: Adding a new UT for fb_array Stephen Hemminger
2023-05-16 13:39 ` Burakov, Anatoly
2023-05-16 14:25 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1673615567-20873-2-git-send-email-vipinp@vmware.com \
--to=vipinp@vmware.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).