From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f170.google.com (mail-wj0-f170.google.com [209.85.210.170]) by dpdk.org (Postfix) with ESMTP id D687E106A for ; Thu, 8 Dec 2016 16:04:44 +0100 (CET) Received: by mail-wj0-f170.google.com with SMTP id xy5so390480026wjc.0 for ; Thu, 08 Dec 2016 07:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=8xsnV/hZ7QMO6KfeJrpGC8Z+BTpv4vHa6Pnq7tLwRWw=; b=O88RFBcbcwLR3ehhjDihkJj/BLn5fIegwY/1zix20Ngp5SkhH1Q/ka4eMwSY9ugYK/ 1SWfzJy88e3KNBv3o/oOd1W/EqSNy/t4PQUNMf+wB4EiabQ6yCcn8V1hQokCtRT0H7dh +nvdv/pXCGOFNVNl289QXU13DTv/KsG5kYtktf/0uxK4j4Mnur16nYc8UQnjMYHHqIcc uO36e1v3IoqzjkNwtMg77MHDDcFotjKFbcW3zpk+WWGishdCJdFZo0e6tjIuPeieoRGT efK7Lqm+kXDHOp2L7CRys8YKchERmrwk6+cbVGeU7qQ8NfxSan57bIIG7Vd2SzLK/FKr xFUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=8xsnV/hZ7QMO6KfeJrpGC8Z+BTpv4vHa6Pnq7tLwRWw=; b=FQOD8ggVS30h9AexliRV3VzGISJJ2aQpX4eLQFDubgw7/fN5JdVCR4bW3lPHsM0T5/ N8O6fPw0IXrd9Nt4TEDwu3dkmlTkmHw+8ZuQnRV4g3mkvdKTIuQcbKGo/O1q0tKGXG8N bAgwiHElknu67+LGotGrhKfA8wm8uqgO4cOqjMlLh8yUEXZrhG6oLRuJJeKCNJZRpK0U H/jbhjDE0aX+NuheA7rWhzwJuID7U5lL1T8AlDCc9P40iuByCSmbXECgnE8wlQ0DQ1Mj y691NwZAAxmVvcUesppetRNfaVKwEpBb1vVLLLcGl7CvMxK/19HpTtGag5eKidNZMz45 85QQ== X-Gm-Message-State: AKaTC02S4qHwWm4RRVVlCAbBgxLqXZ0jzFEzXJj5vRRebkrK8I7R+U0p1PGb9R5Nh5aw90Dk X-Received: by 10.194.123.201 with SMTP id mc9mr78187263wjb.47.1481209484234; Thu, 08 Dec 2016 07:04:44 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id y4sm37484339wjp.0.2016.12.08.07.04.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Dec 2016 07:04:43 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org Date: Thu, 08 Dec 2016 16:04:42 +0100 Message-ID: <1674430.9Jmj4il0P5@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161207182717.1fdb0851@xeon-e3> References: <20161207182717.1fdb0851@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC] ethdev: expand size of eth_dev_name in next release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 15:04:45 -0000 2016-12-07 18:27, Stephen Hemminger: > In order to support Hyper-V in a direct fashion, the eth_dev name > needs to be expanded. The standard format for text representation of GUID > is 36 bytes (plus null). See uuid_unparse(3). [...] > --- a/doc/guides/rel_notes/release_17_02.rst > +++ b/doc/guides/rel_notes/release_17_02.rst > @@ -116,7 +116,9 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ========================================================= > > - > + * The macro ``RTE_ETH_NAME_MAX_LEN`` used in rte_eth_dev_data will be > + increased from 32 to 40 characters to allow for longer values such > + as GUID which is 36 characters long (plus null character). Please start at the margin and keep the double blank lines before the next title. > Shared Library Versions > ----------------------- > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 9678179..68cb956 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1652,7 +1652,11 @@ struct rte_eth_dev_sriov { > }; > #define RTE_ETH_DEV_SRIOV(dev) ((dev)->data->sriov) > > +#ifdef RTE_NEXT_ABI > +#define RTE_ETH_NAME_MAX_LEN 40 > +#else > #define RTE_ETH_NAME_MAX_LEN (32) > +#endif No need for RTE_NEXT_ABI as it was planned to break ethdev ABI for several reasons (see doc/guides/rel_notes/deprecation.rst). Note that we should continue the discussion about the ABI process, but I prefer avoiding this debate during December as we are really too busy until the RC1.