From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2402A0562; Tue, 4 May 2021 14:17:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A77140147; Tue, 4 May 2021 14:17:00 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id E774140141 for ; Tue, 4 May 2021 14:16:58 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 65C0F1639; Tue, 4 May 2021 08:16:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 04 May 2021 08:16:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Cq09FT47JBydHjkUSXkrlsp0THdcWZrkoirLa3sbgbs=; b=ff1CnawYQwvi4ROx dYxsv6aZ79WMtkThNtH/qUi7CDyk8wE3y392yiD2MS3XiIqHDkYrfD1ZnhvpxrxF dAwcMTqc2s3OmgPQS6xtG+xUjgI/fmIKJIgfDXX5FoBH4EnG2ohEX2Im2A+XwcWF 2/dAU0Zn4Tgomi4CLovvbhIecSOylWjJusvSSSX5b5bKo4tQW1iiZdR06YdwIVSf gVg4pRQ1pogS0ZUv4lwFiyE9K4ggVXDvkz231VTav0aJYrmpC5C59yYIgo3cqQNm N0CsYTwDZOVKEvlTAkhstoM/QjPzNAEoLyVbteSDKkiwz8Kq7Phi4da9kvh8Z9+a Zr8qNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Cq09FT47JBydHjkUSXkrlsp0THdcWZrkoirLa3sbg bs=; b=TmeDGqTmoiGIa8aILzSYLRRC9dA6fKktaUt7FYA7M9O7N/TCvfF4c8Tds rKe0ysHsaR5/Spa8+lmA57HDehXhVbuB1D1J9EXRi5GOGs5+Q95g0jgJ6KYN95eU EA9syx1iLY0g2mjC2Lwq+sTrnHZYeUauUJOKsvuS9X7Uvpw+lBJSrKGa+UOmLjJM M50HR4c5FPH9I5BD3JvA/deZSLyIDTIhs3q/B86EtITXQ0MkCjB5Kd5biRgOJUcF 0idOpC5TbrFjX2MZNlRn65C3V5wPDOemotvEQPr33G2kWjEUWecU+/cQE9+pBjFS 0lqLEQyPu8b4vAg5Ic8USI6vBUc4Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 May 2021 08:16:55 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, kevin.laatz@intel.com, sunil.pai.g@intel.com, jiayu.hu@intel.com Date: Tue, 04 May 2021 14:16:52 +0200 Message-ID: <1674948.ao2C6ssIZq@thomas> In-Reply-To: References: <20210318182042.43658-1-bruce.richardson@intel.com> <10801772.08G8JL9ftu@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 04/12] raw/ioat: add explicit padding to descriptor struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/05/2021 14:04, Bruce Richardson: > On Mon, May 03, 2021 at 11:20:40PM +0200, Thomas Monjalon wrote: > > 30/04/2021 17:06, Bruce Richardson: > > > Add an explicit padding field to the end of the descriptor structure so > > > that when the batch descriptor is defined on the stack for perform-ops, the > > > unused space is all zeroed appropriately. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > --- a/drivers/raw/ioat/rte_ioat_rawdev_fns.h > > > +++ b/drivers/raw/ioat/rte_ioat_rawdev_fns.h > > > - /* 28 bytes of padding here */ > > > + uint16_t intr_handle; /* completion interrupt handle */ > > > > This is more than padding. > > Does it deserve its own commit? > > > > This field is unused by the driver, since we don't use any interrupts, so I > consider it as padding in that regard. However, I agree that in reality > it's not padding, but I think rather than having it's own commit, I can > just reword the patch commit log to cover it. Something like: > > raw/ioat: expand descriptor struct to full 64 bytes > > Although it's unused by the driver, add the interrupt handle field in the > descriptor to the descriptor structure for completeness, and explicitly add > the reserved padding field on the end of the structure too. This means that > when a descriptor is defined on the stack, or initialized by the compiler, > the unused/reserved space will be zeroed appropriately. OK, thanks for adding full explanation in the git history.