From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA4C4A0524; Tue, 20 Apr 2021 03:08:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB01341554; Tue, 20 Apr 2021 03:08:16 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 2032241448 for ; Tue, 20 Apr 2021 03:08:15 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id B1C265C00CF; Mon, 19 Apr 2021 21:08:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Apr 2021 21:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 65XETSDcF4ry+ZZBSIA8H61i8nEVt/z9+oAaJlh5nKA=; b=TBtltwNOfU1lrKSp Ldib/1MO3KyjmeaotFTRC6sAa7qf6vvK0lrbgftJKmb0/9eKZtB931KhykNoR7Dy dMxfZbo4zQP7J2qMPMKXJ/Rxkzt30ecizdRzGwWAi5APZSSt8Rki1uuooElvplIJ USg6DESVTSPrWoawWODvbgRMqXO/V/p/VmFEoQUtmHd3yx65wB4FUtrf1zgAksrZ +nAsaHV7DFVjJ0ode9PiI1mC/KS3xUa2u1l1pYGJgAOmfpp+ryL5eSAef0JsG6Ru UFEqdIPKaG8kyvAExSvfp05zuAAOn6PjirVwKHH+3H+18NL1LT2rfmm6Guf/26pc 6hywYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=65XETSDcF4ry+ZZBSIA8H61i8nEVt/z9+oAaJlh5n KA=; b=osjA2Ieg+Kg6nEnygc0pQfX+7oeAtpEmNJxKBfVzn02MyTVh5VEAvaQPP XPVTD27wd6pxOjS0dE8t6RXNshM/+IdVnlA1Eik1DxniXADsHF8tH//h47g2GR81 1tr8mIOKbfq6IeFIufKL4McsUyJty7nLCiucY3ddVd3hF9r7vdUtAfDfPHbOZtVy qvf8O2/SJqHi6lOEvnxGq+w8Jk2k1NKKJ21JumGIuXbsnMzqamqZrqoGkBB51Sha fqiSwCBRQ+my6T4JSAW2XdUKM9WP2qKFs8uxLVndzWRV5EJ/THKKXB2mabFOOaJP Z2/G0BpjhsjLkJw80JhS54vTl2VjA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddthedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BEA5A108005F; Mon, 19 Apr 2021 21:08:12 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com, bernard.iremonger@intel.com, tomasz.kantecki@intel.com, bruce.richardson@intel.com, anatoly.burakov@intel.com, david.marchand@redhat.com Date: Tue, 20 Apr 2021 03:08:11 +0200 Message-ID: <1675114.mf6Gbu22uX@thomas> In-Reply-To: <1616830818-3127-2-git-send-email-humin29@huawei.com> References: <1616830818-3127-1-git-send-email-humin29@huawei.com> <1616830818-3127-2-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] examples/flow_classify: fix check of port and core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/03/2021 08:40, Min Hu (Connor): > fix check of port and core in flow_classify example. > > Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) > --- > RTE_ETH_FOREACH_DEV(port) > - if (rte_eth_dev_socket_id(port) > 0 && > + if (rte_eth_dev_socket_id(port) >= 0 && > rte_eth_dev_socket_id(port) != (int)rte_socket_id()) { > printf("\n\n"); > printf("WARNING: port %u is on remote NUMA node\n", Please explain which case is broken and why. If I understand well, we don't detect remote NUMA if not running on first socket.