DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: miroslaw.walukiewicz@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pmd: Add generic support for TCP TSO (Transmit Segmentation Offload)
Date: Mon, 20 Oct 2014 13:30:07 +0200	[thread overview]
Message-ID: <1675767.ObibVazTHA@xps13> (raw)
In-Reply-To: <20141020094252.14456.58891.stgit@gklab-18-011.igk.intel.com>

Hi Miroslaw,

I'll try to comment your patch, but I don't know if you'll receive it.
Indeed, you didn't reply to the previous comments.
Please configure your email client to receive these emails.
This is not a write-only list.

2014-10-20 05:42, miroslaw.walukiewicz@intel.com:
> Add new  PKT_TX_TCP_SEG flag
> Add new fields in the tx offload fields indicating MSS and L4 len

You should explain why these additions are needed.

>  	/* fields to support TX offloads */
> -	union {
> -		uint16_t l2_l3_len; /**< combined l2/l3 lengths as single var */
> -		struct {
> -			uint16_t l3_len:9;      /**< L3 (IP) Header Length. */
> -			uint16_t l2_len:7;      /**< L2 (MAC) Header Length. */
> +	/* two bytes - l2/l3 len for compatibility (endian issues)
> +	 * two bytes - reseved for alignment
> +	 * two bytes - l4 len (TCP/UDP) header len
> +	 * two bytes - TCP tso segment size 
> + 	 */
> +	struct {
> +		union {
> +			uint16_t l2_l3_len; /**< combined l2/l3 len */
> +			struct {
> +				uint16_t l3_len:9; /**< L3 (IP) Header */
> +				uint16_t l2_len:7; /**< L2 (MAC) Header */
> +			};
>  		};

Why nesting these fields in an anonymous structure?

> +		uint16_t reserved_tx_offload;
> +		uint16_t l4_len;            /**< TCP/UDP header len */
> +		uint16_t tso_segsz;         /**< TCP TSO segment size */
>  	};

What means reserved_tx_offload?

Is there an impact on performance of actual drivers ?

How this patch is related with previous work in progress about TSO?

-- 
Thomas

  reply	other threads:[~2014-10-20 11:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20  9:42 miroslaw.walukiewicz
2014-10-20 11:30 ` Thomas Monjalon [this message]
2014-10-20 12:45   ` Walukiewicz, Miroslaw
2014-10-20 13:51     ` Thomas Monjalon
2014-10-20 14:03       ` Walukiewicz, Miroslaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1675767.ObibVazTHA@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=miroslaw.walukiewicz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).