From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 679A76A96 for ; Mon, 20 Oct 2014 13:22:12 +0200 (CEST) Received: by mail-wg0-f48.google.com with SMTP id k14so5149745wgh.31 for ; Mon, 20 Oct 2014 04:30:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5Voe5v8DivS4jPhr6f+esPsXHglpU0UYlUTq4G1sa10=; b=ANFKZICRukGcFKW0pQDoLPB5VGkrnx3uCiczDwOpQrXiCgZ/Ex/rEa07YS2kLsoYI4 IHLRLsnCZu9GpSxWk24g87DdTTrCF+vEJcAgc11aQfsdd1wVqmGPMdNTT4d576WQVuQp bVlrYwoETxuqANjU1oD8abty+P/buCaquiom94yV9Kgda2aLXMs761AP1OwLnRAb33ic X0SJjtpiHnM0QLFjamuiDDOAX5yUebj3hgHe27JLI1P6slMqxOWHWJ73mMiuojNbyO3u z2BDcYA2Dey6Gi4qO0rc3k3DJkPnHJLwb3+xnl8mGnEETnN5jbH1HYI//y5+YrAhM387 CcHA== X-Gm-Message-State: ALoCoQnd6GteWg3gLrytpWRoLEFj/XPc5+yZxvkUik4MbVDtzAgKDUaEZQGU2kWfjlhSZZQNMQBa X-Received: by 10.194.93.194 with SMTP id cw2mr3515366wjb.112.1413804623122; Mon, 20 Oct 2014 04:30:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l10sm9282272wif.20.2014.10.20.04.30.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Oct 2014 04:30:22 -0700 (PDT) From: Thomas Monjalon To: miroslaw.walukiewicz@intel.com Date: Mon, 20 Oct 2014 13:30:07 +0200 Message-ID: <1675767.ObibVazTHA@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <20141020094252.14456.58891.stgit@gklab-18-011.igk.intel.com> References: <20141020094252.14456.58891.stgit@gklab-18-011.igk.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pmd: Add generic support for TCP TSO (Transmit Segmentation Offload) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Oct 2014 11:22:12 -0000 Hi Miroslaw, I'll try to comment your patch, but I don't know if you'll receive it. Indeed, you didn't reply to the previous comments. Please configure your email client to receive these emails. This is not a write-only list. 2014-10-20 05:42, miroslaw.walukiewicz@intel.com: > Add new PKT_TX_TCP_SEG flag > Add new fields in the tx offload fields indicating MSS and L4 len You should explain why these additions are needed. > /* fields to support TX offloads */ > - union { > - uint16_t l2_l3_len; /**< combined l2/l3 lengths as single var */ > - struct { > - uint16_t l3_len:9; /**< L3 (IP) Header Length. */ > - uint16_t l2_len:7; /**< L2 (MAC) Header Length. */ > + /* two bytes - l2/l3 len for compatibility (endian issues) > + * two bytes - reseved for alignment > + * two bytes - l4 len (TCP/UDP) header len > + * two bytes - TCP tso segment size > + */ > + struct { > + union { > + uint16_t l2_l3_len; /**< combined l2/l3 len */ > + struct { > + uint16_t l3_len:9; /**< L3 (IP) Header */ > + uint16_t l2_len:7; /**< L2 (MAC) Header */ > + }; > }; Why nesting these fields in an anonymous structure? > + uint16_t reserved_tx_offload; > + uint16_t l4_len; /**< TCP/UDP header len */ > + uint16_t tso_segsz; /**< TCP TSO segment size */ > }; What means reserved_tx_offload? Is there an impact on performance of actual drivers ? How this patch is related with previous work in progress about TSO? -- Thomas