From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BB73A00C2; Thu, 10 Feb 2022 08:57:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88E374013F; Thu, 10 Feb 2022 08:57:21 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 62F1540041 for ; Thu, 10 Feb 2022 08:57:19 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 00B003200BF9; Thu, 10 Feb 2022 02:57:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 10 Feb 2022 02:57:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=EhhIV2ANz66GTF f7bpXP3eYbuxAx3qTxnyI8a4Aok68=; b=me3lPalns3sEpWr5NX413pGp7NE9up LvR/I03FurI1XRQ4Jwrq4GqltqMRU4/CpQz/5JOKes2YUn15Vmi2dgA3rHZ8VmXk hGxqHXNpTdYqiKff2uA6gCeDAgc6Xah7RXVv29VPtAg24AbALr6/qVJjQhIOu5qJ l/yx3Hyb4apE+PWFSEu+Sa0++kwzs69gsX6ebzgaceilXdgd5AWnIFEC9lvvvtnS 7sxpjgeZAH/NoAeTMAUK35kmmzq3gf1fw9IJhDZkc0CjOp0Pe097EA1hPadfSRBt voDtDsBSgVzZdgQiCic8wEO+zIlYjlmNtLTCfbGBSM/GYeYyR5DPp6Zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=EhhIV2ANz66GTFf7bpXP3eYbuxAx3qTxnyI8a4Aok 68=; b=a3nnhyoWWlppLf110UrLlE0cMzgtc7tyf6YNfFo8Gg0tQwW2noKCUlW80 WzBfq/fSsvtP6nNXBdE3fauAgNu9iOxAUJbq/CzAhb/vvucpERkrs/J6fI/IFhBQ AoGnu76HtzwwC/g6bdhxCkm7gZGhxCxUHldf0sTBpMevujieu6E6Pg4oXSUHsUAS B6wem52+KejSJ2GeyusKDV5FDE5kdK6/3OtaEFanX84ZxYyD04g60v9wMGcXHHEI wDcjGtmq+ng35fhHv44Uk1G8S4hP7OmTXuyVOT0WHRo5FrcECMG79TRzXiwSuy3S e03JvqMFnHknFrF6ZmI1CRdGe34+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddriedtgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Feb 2022 02:57:16 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger , david.marchand@redhat.com Subject: Re: [PATCH] eal: remove unnecessary argv[0] handling Date: Thu, 10 Feb 2022 08:57:14 +0100 Message-ID: <1676675.QkHrqEjB74@thomas> In-Reply-To: <20220209112949.7742991d@hermes.local> References: <20220202194738.404876-1-stephen@networkplumber.org> <37375521.10thIPus4b@thomas> <20220209112949.7742991d@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/02/2022 20:29, Stephen Hemminger: > On Wed, 09 Feb 2022 19:51:15 +0100 > Thomas Monjalon wrote: > > > 09/02/2022 16:45, Stephen Hemminger: > > > On Wed, 09 Feb 2022 15:58:26 +0100 > > > Thomas Monjalon wrote: > > > > > > > 02/02/2022 20:47, Stephen Hemminger: > > > > > The rte_eal_init function looks at argv[0] to determine > > > > > the program name to pass to the log init function. > > > > > This is both unnecessary and in a corner case a problem. > > > > > > > > > > Parsing argv[0] is unnecessary because the function openlog() > > > > > already determines the log identifier from program name if > > > > > NULL is passed, see openlog man page: > > > > > The string pointed to by ident is prepended to every message, and is > > > > > typically set to the program name. If ident is NULL, the program name > > > > > is used. (POSIX.1-2008 does not specify the behavior when ident is > > > > > NULL.) > > > > > > > > What about POSIX warning? > > > > Did you test it? Which libc? What about musl? > > > > > > Source for musl shows that openlog accepts NULL as ident. > > > It then generates log messages with ident in the message. > > > > In this case, it will be empty string. > > It seems this solution does not work with musl. > > Good news: musl is available as debian package > Bad news: DPDK build is broken with musl > > > Library IPSec_MB found: YES > > drivers/crypto/ipsec_mb/meson.build:19:4: ERROR: Could not get define 'IMB_VERSION_STR' This error is not related to musl. Compilation on Alpine (with musl) is tested regularly, it works for me.