From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F8A841DAF; Thu, 2 Mar 2023 01:49:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C0CB42D2C; Thu, 2 Mar 2023 01:48:16 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E69B6427E9 for ; Thu, 2 Mar 2023 01:48:03 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B9BEB20BC5F4; Wed, 1 Mar 2023 16:48:02 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B9BEB20BC5F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1677718082; bh=to9l92+D8cNrm2Iv3jh+V+7N5U6IhuqoNrrLXMKesko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qFRZMVZlmuBla0SrpZdJAIb22k7tegO2keLSvaO8xpelyIpQhlF19PfC0Q8+q7UTR ehkhBW32DXTdEZWT3loU4m0kMcQI59nQncZu7ejKdBsbBREifRq3P/neAYSUtCA2H8 Crq47dAqI+gKu59r1Hc/YEuQq2bSacMQOnWU2TcA= From: Tyler Retzlaff To: dev@dpdk.org Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, Tyler Retzlaff Subject: [PATCH 17/17] test-eventdev: use previous value atomic fetch operations Date: Wed, 1 Mar 2023 16:47:48 -0800 Message-Id: <1677718068-2412-18-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com> References: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in C11 standard and will reduce review effort when they are integrated. Signed-off-by: Tyler Retzlaff --- app/test-eventdev/test_order_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h index 92781d9..1507265 100644 --- a/app/test-eventdev/test_order_common.h +++ b/app/test-eventdev/test_order_common.h @@ -113,7 +113,7 @@ struct test_order { */ expected_flow_seq[flow]++; rte_pktmbuf_free(ev->mbuf); - __atomic_sub_fetch(outstand_pkts, 1, __ATOMIC_RELAXED); + __atomic_fetch_sub(outstand_pkts, 1, __ATOMIC_RELAXED); } static __rte_always_inline void -- 1.8.3.1