From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A33B41DB5; Thu, 2 Mar 2023 17:18:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B951242BAC; Thu, 2 Mar 2023 17:18:32 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B970D40E2D for ; Thu, 2 Mar 2023 17:18:30 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0E48320B9C3F; Thu, 2 Mar 2023 08:18:29 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0E48320B9C3F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1677773910; bh=YD1SW02XSbkTUBFn0v/KNqbz35MAadZTPtPYVxRadWQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQYLKJFAWPzt0BvZ62bGRyIz++mWvw5xntpcHelyTwlvS61mVPJeI1PX8xBb1OY5k Ue3ZC6soEooFshJ1R/bm7xZU8Xb3SdWnD2K2MIXM/9r012XnZQLuZTgzppewA1v/+o 14Nxwd3+xgAHpuySn9tfQsrcwO0H0EkSxht4uDWg= From: Tyler Retzlaff To: dev@dpdk.org Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, bruce.richardson@intel.com, mb@smartsharesystems.com, Ruifeng.Wang@arm.com, maxime.coquelin@redhat.com, Tyler Retzlaff Subject: [PATCH v2 02/17] telemetry: use previous value atomic fetch operations Date: Thu, 2 Mar 2023 08:18:07 -0800 Message-Id: <1677773902-5167-3-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1677773902-5167-1-git-send-email-roretzla@linux.microsoft.com> References: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com> <1677773902-5167-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in C11 standard and will reduce review effort when they are integrated. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/telemetry/telemetry.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index 7bceadc..deba7f3 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/telemetry/telemetry.c @@ -391,7 +391,7 @@ struct socket { bytes = read(s, buffer, sizeof(buffer) - 1); } close(s); - __atomic_sub_fetch(&v2_clients, 1, __ATOMIC_RELAXED); + __atomic_fetch_sub(&v2_clients, 1, __ATOMIC_RELAXED); return NULL; } @@ -414,7 +414,7 @@ struct socket { close(s_accepted); continue; } - __atomic_add_fetch(s->num_clients, 1, + __atomic_fetch_add(s->num_clients, 1, __ATOMIC_RELAXED); } rc = pthread_create(&th, NULL, s->fn, @@ -424,7 +424,7 @@ struct socket { strerror(rc)); close(s_accepted); if (s->num_clients != NULL) - __atomic_sub_fetch(s->num_clients, 1, + __atomic_fetch_sub(s->num_clients, 1, __ATOMIC_RELAXED); continue; } -- 1.8.3.1