From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id A2E085323
 for <dev@dpdk.org>; Tue, 25 Aug 2015 14:38:10 +0200 (CEST)
Received: by widdq5 with SMTP id dq5so13752393wid.0
 for <dev@dpdk.org>; Tue, 25 Aug 2015 05:38:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=mwbHumuYJx+uNbO4tNBbboBOTmokKFgpyWi6biptLfc=;
 b=PsPV03A55f++hVJSVoiM94gSB0819RhUX+9jRya0ZS34wy5T4lXObykDIbTqu4TavR
 pbbG7AvUYcGigeO/kBoWvnVPwTijbKptQLdXNlOwfnnpZOQMWh78Wmzzi5uJr/SzVaXO
 i1HkHoAFc+N+0KrffPjPl9FSgFAVw6BJwiPSldEbIC4kdwO16r7owC13Cmiv3b2FdbAk
 3V3oxqML1U0CQrsDZIgb40fxXOZMY2zU1bxiKPn1liCA0woCPomxX5k2LjTpFg4B1VfA
 ydxB3WnEQe23P2n8Z4eoJ3a/wmaArt7oBS2W/aYe44OKDItK46qf45RzJjd1PW41hPbG
 EbtQ==
X-Gm-Message-State: ALoCoQm+qY+7hWYDVWkH/CB02HUEUF/FCEVYhYt4cXlN5w4yMsAeA0+PgFQifR6qzxwOoWhYd1BC
X-Received: by 10.180.81.70 with SMTP id y6mr4327110wix.36.1440506290502;
 Tue, 25 Aug 2015 05:38:10 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id du6sm2467798wib.24.2015.08.25.05.38.09
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 25 Aug 2015 05:38:09 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Date: Tue, 25 Aug 2015 14:36:59 +0200
Message-ID: <1677849.ZVAMZEjUYk@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1439913312-14761-1-git-send-email-ian.stokes@intel.com>
References: <1439913312-14761-1-git-send-email-ian.stokes@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Aug 2015 12:38:10 -0000

2015-08-18 16:55, Ian Stokes:
> The qos_meter sample app will fail to compile if APP_MODE
> is set to APP_MODE_FWD. This patch changes the variable
> name 'color' in main.h to the expected variable name
> 'input_color' to allow compilation with APP_MODE_FWD.

Thanks for raising the issue.

> --- a/examples/qos_meter/main.h
> +++ b/examples/qos_meter/main.h
>  #if APP_MODE == APP_MODE_FWD
>  
> -#define FUNC_METER(a,b,c,d) color, flow_id=flow_id, pkt_len=pkt_len, time=time
> +#define FUNC_METER(a,b,c,d) input_color, flow_id=flow_id, pkt_len=pkt_len, time=time

This patch should not be accepted to discourage build-time options.
Patch for run-time option is welcome.