From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com,
thomas@monjalon.net,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH 15/16] mbuf: use previous value atomic fetch operations
Date: Fri, 10 Mar 2023 14:15:29 -0800 [thread overview]
Message-ID: <1678486530-20688-16-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>
Use __atomic_fetch_{add,and,or,sub,xor} instead of
__atomic_{add,and,or,sub,xor}_fetch adding the necessary code to
allow consumption of the resulting value.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/mbuf/rte_mbuf.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index 3a82eb1..5da4cbe 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -381,8 +381,8 @@ struct rte_pktmbuf_pool_private {
static inline uint16_t
__rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value)
{
- return __atomic_add_fetch(&m->refcnt, (uint16_t)value,
- __ATOMIC_ACQ_REL);
+ return __atomic_fetch_add(&m->refcnt, (uint16_t)value,
+ __ATOMIC_ACQ_REL) + (uint16_t)value;
}
/**
@@ -502,8 +502,8 @@ struct rte_pktmbuf_pool_private {
return (uint16_t)value;
}
- return __atomic_add_fetch(&shinfo->refcnt, (uint16_t)value,
- __ATOMIC_ACQ_REL);
+ return __atomic_fetch_add(&shinfo->refcnt, (uint16_t)value,
+ __ATOMIC_ACQ_REL) + (uint16_t)value;
}
/** Mbuf prefetch */
@@ -1315,8 +1315,8 @@ static inline int __rte_pktmbuf_pinned_extbuf_decref(struct rte_mbuf *m)
* Direct usage of add primitive to avoid
* duplication of comparing with one.
*/
- if (likely(__atomic_add_fetch(&shinfo->refcnt, (uint16_t)-1,
- __ATOMIC_ACQ_REL)))
+ if (likely(__atomic_fetch_add(&shinfo->refcnt, (uint16_t)-1,
+ __ATOMIC_ACQ_REL) + (uint16_t)-1))
return 1;
/* Reinitialize counter before mbuf freeing. */
--
1.8.3.1
next prev parent reply other threads:[~2023-03-10 22:17 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 22:15 [PATCH 00/16] use __atomic operations returning new value Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 02/16] common/cnxk: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 03/16] common/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 04/16] drivers/event: " Tyler Retzlaff
2023-03-13 7:02 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-03-10 22:15 ` [PATCH 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 06/16] net/cnxk: " Tyler Retzlaff
2023-03-13 6:45 ` [EXT] " Nithin Kumar Dabilpuram
2023-03-10 22:15 ` [PATCH 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 08/16] net/iavf: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 09/16] net/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 10/16] net/octeontx: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 12/16] bbdev: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 13/16] eal: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 14/16] ipsec: " Tyler Retzlaff
2023-03-10 22:15 ` Tyler Retzlaff [this message]
2023-03-10 22:15 ` [PATCH 16/16] rcu: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 00/16] replace __atomic operations returning new value Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 02/16] common/cnxk: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 03/16] common/mlx5: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 04/16] drivers/event: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 06/16] net/cnxk: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 08/16] net/iavf: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 09/16] net/mlx5: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 10/16] net/octeontx: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 12/16] bbdev: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 13/16] eal: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 14/16] ipsec: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 15/16] mbuf: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 16/16] rcu: " Tyler Retzlaff
2023-03-16 10:03 ` [PATCH v2 00/16] replace __atomic operations returning new value Bruce Richardson
2023-03-16 15:25 ` Thomas Monjalon
2023-03-16 16:17 ` Tyler Retzlaff
2023-04-18 18:11 ` Tyler Retzlaff
2023-03-20 10:24 ` Ruifeng Wang
2023-03-20 19:00 ` [PATCH v3 " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 02/16] common/cnxk: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 03/16] common/mlx5: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 04/16] drivers/event: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 06/16] net/cnxk: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 08/16] net/iavf: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 09/16] net/mlx5: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 10/16] net/octeontx: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 12/16] bbdev: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 13/16] eal: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 14/16] ipsec: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 15/16] mbuf: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 16/16] rcu: " Tyler Retzlaff
2023-04-25 9:10 ` [PATCH v3 00/16] replace __atomic operations returning new value David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1678486530-20688-16-git-send-email-roretzla@linux.microsoft.com \
--to=roretzla@linux.microsoft.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).