From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9D6C71BF45; Wed, 27 Jun 2018 23:14:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2862621B89; Wed, 27 Jun 2018 17:14:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Jun 2018 17:14:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=p51kxQG/+oOKlB+x03Ymbq4WoU nwP/ZRmy2NkffqyKc=; b=pUyQXg+br6AyruJdr9aEGOLfLOPAvh/0jU9f4aMv0m cu9t7F4H+gwBMdVGEYRaSR8Cn+S6GqD/VW78X88/Au/zPRD5O7whsXHYCdwamacq ZCv1rkdvE+eQqFPEh9c+sgbXk5O19FdIN1ms0eFeQ1s7BAAaMWLKTEqMudeZvqXl M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=p51kxQ G/+oOKlB+x03Ymbq4WoUnwP/ZRmy2NkffqyKc=; b=IR3/u+RW4QWrTFx1lICKMh nOD2a62F6jL1YcXxde5PKTGhzPuZUid2Eg2N103Mh3HIjtANJzbDuMBJWH459Sse 26JtLyNyUTGMlefpn6arRTrEJQvZGHpqHQjwj80bv/r3Z70iXKnKoRqHWn79OKSD z2bMhwoRnEVEiqf0GSs/XBUNNdRYYrRBZMcQ1YpQnWzA4rc/GBO2pWhghu5L3ie4 R95vqJbhfIe61ZcYgE+To5xSg7aE5/wYX9uD4PyfZ8wsSD6bOPf7EvsoEgwQB5FH fBKbJAudhJrPQKm4GkA6ASpg46ZOcg4dc4yHzff2tnmouASMTjVSuE9L/ZyHl9tw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E573910260; Wed, 27 Jun 2018 17:13:59 -0400 (EDT) From: Thomas Monjalon To: Gavin Hu Cc: stable@dpdk.org, dev@dpdk.org, nd@arm.com Date: Wed, 27 Jun 2018 23:13:58 +0200 Message-ID: <1678634.Uv4K4bE778@xps> In-Reply-To: <20180625024913.17219-5-gavin.hu@arm.com> References: <20180619103657.19186-1-gavin.hu@arm.com> <20180625024913.17219-1-gavin.hu@arm.com> <20180625024913.17219-5-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v13 4/6] devtools: fix the missing ninja command error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 21:14:01 -0000 25/06/2018 04:49, Gavin Hu: > On some linux distributions, eg: CentOS, the ninja executable has a > different name: ninja-build, this patch is to check and adapt to it > accordingly. > > ./devtools/test-meson-builds.sh: line 24: ninja: command not found > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang > Reviewed-by: Song Zhu > Acked-by: Bruce Richardson > --- > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > +if command -v ninja >/dev/null 2>&1 ; then > + ninja_cmd=ninja > +elif command -v ninja-build >/dev/null 2>&1 ; then > + ninja_cmd=ninja-build > +else > + echo "## ERROR: ninja is missing, please install..." No need of double hash to get attention as it is the last printed line. Matter of taste, but I prefer more simple (not interpreted) message like: "ERROR: ninja is not found" Or even simpler, no message at all and try with ninja_cmd=ninja as default: if command -v ninja-build >/dev/null 2>&1 ; then ninja_cmd=ninja-build else ninja_cmd=ninja fi Will still have the shell message in case of ninja not installed: ninja: command not found