From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 4C92080E2
 for <dev@dpdk.org>; Mon, 24 Nov 2014 18:55:07 +0100 (CET)
Received: by mail-wg0-f42.google.com with SMTP id z12so13189259wgg.29
 for <dev@dpdk.org>; Mon, 24 Nov 2014 10:05:56 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=WUQhFWuXwmZJZz7/XoH/TVyGUnjdgnB9i02JkTtrj8U=;
 b=VrBoHATYhgjsfzvzS+XyaL4FHoMCZdiEQ9IVlPB680rJ2xvaY8KmUJKbW20dUa3BA1
 7Yv/cEqfIDJbs5FAhj4yr9H5ulnsAtTLacPz6TtmLPkY18ACIJjA68nhfBAY979IiCeu
 IjQRwmegUMVErsWvABi6E8oek6Ik5aY7PzHs6/zuw9wHMgcaUeSw/o0ta34jB2Ge7f+g
 6qzGan+fXf6IsCTeIueph+HDpQhNiCFakpXftBwRi4AtWfyEL5zfR33njx6PHqx2iFRt
 +K5yzC2NI6KY3RCNYBJqklx+Mjh3uR/7ebJK2tNVP8KP9tIZByJ5KDgQHQJlzlcX96I5
 6oDw==
X-Gm-Message-State: ALoCoQmab6WWGH/VlsxUqBUXbKZQId8HO/J45rmXTqofZLWDEBMjjMdp253m5TzZ38EkmRrqvHP/
X-Received: by 10.180.228.37 with SMTP id sf5mr24371484wic.35.1416852356103;
 Mon, 24 Nov 2014 10:05:56 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id n3sm22035077wjz.21.2014.11.24.10.05.54
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 24 Nov 2014 10:05:55 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>,
 Pawel Wodkowski <pawelx.wodkowski@intel.com>
Date: Mon, 24 Nov 2014 19:05:32 +0100
Message-ID: <1679332.pWPR9Gg93t@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <1416849181-17183-2-git-send-email-michalx.k.jastrzebski@intel.com>
References: <1416849181-17183-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1416849181-17183-2-git-send-email-michalx.k.jastrzebski@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/2] bond: add mode 4 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2014 17:55:07 -0000

2014-11-24 17:13, Michal Jastrzebski:
> From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>

As I've already requested, we need some explanations.
The minimum is to explain what is mode 4 or give inputs.
It won't be integrated without it. Wednesday is the deadline for this stuff.

> ---
>  lib/librte_ether/rte_ether.h                      |    1 +
>  lib/librte_pmd_bond/Makefile                      |    2 +
>  lib/librte_pmd_bond/rte_eth_bond.h                |    5 +
>  lib/librte_pmd_bond/rte_eth_bond_8023ad.c         | 1218 +++++++++++++++++++++
>  lib/librte_pmd_bond/rte_eth_bond_8023ad.h         |  214 ++++
>  lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h |  308 ++++++
>  lib/librte_pmd_bond/rte_eth_bond_api.c            |   91 +-
>  lib/librte_pmd_bond/rte_eth_bond_args.c           |    1 +
>  lib/librte_pmd_bond/rte_eth_bond_pmd.c            |  262 ++++-
>  lib/librte_pmd_bond/rte_eth_bond_private.h        |   31 +-

For a such big development, there are probably some interesting things to
explain about design, performance, etc.
Be proud of your work!

-- 
Thomas