From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <shemming@brocade.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly.
Date: Fri, 17 Jul 2015 10:15:12 +0200 [thread overview]
Message-ID: <1679490.KK3tNg9jEu@xps13> (raw)
In-Reply-To: <20150716194920.3710f25e@urahara>
2015-07-16 19:49, Stephen Hemminger:
> On Fri, 17 Jul 2015 00:52:09 +0000
> "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
>
> > Hi Stephen,
> > I don't think there's a conflict. The message just reminder us that we can adjust the values to achieve better performance.
> > I saw ixgbe and i40e also use 0 as the same default value. To my opinion, it's good to keep the same behavior.
> > Thanks.
>
> In my opnion, no application should have to make special case setup
> for each device type. Having to have a table that lists all the parameters
> for each device name is not supportable or scaleable.
>
> The DPDK started out as "lets do benchmarks fast" but as a production
> toolkit it needs to stop having this kind of thing.
>
> The message shows up to the end-user, who thinks it is a driver bug.
> The "us" is now real customers not DPDK developers.
+1 to have better default values and less scary messages.
next prev parent reply other threads:[~2015-07-17 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 17:16 Stephen Hemminger
2015-07-17 0:52 ` Lu, Wenzhuo
2015-07-17 2:49 ` Stephen Hemminger
2015-07-17 8:15 ` Thomas Monjalon [this message]
2015-07-17 11:06 ` Wiles, Keith
2015-07-20 2:16 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1679490.KK3tNg9jEu@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).