From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 455706942 for ; Fri, 17 Jul 2015 10:16:24 +0200 (CEST) Received: by wibud3 with SMTP id ud3so33291639wib.1 for ; Fri, 17 Jul 2015 01:16:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Ej2KqsalmsvEcKqzFy5cHUzhMRgobqYXq4bwhr4Lnx8=; b=j0XuBbwYnDiZXMPwoQ4briYfgbcCE62HuoGna6F26kh22qt3SEHZqV+AQkZhzbcWUe u+fZoPlbVTxCAbviBSlByGVp6YWmvVQBRG5dLbQsVD8viaKOyPZY0HWmUlfca1ypHkHs Z8/MOZzRGNxCf/lvv8ozAMsqL+M92pCF+poKJxWuBFQXtVH+kmV1TDw7D1yalXH1L6CJ siZgXTeA42cEmpFBQFytKTWvXRq1hhOrZXngVlK+++Gzt5BfWx5IVPIUiCxJaiAI2qPV oQaCE/9mJ9RRWQXeFNqr4n+18Y+TlNF1lmDqX/5KYgAka5SjxSvlctqwvfIpc611ayWz DxOg== X-Gm-Message-State: ALoCoQmOwDMVMSI1Fu5PJ3SwwXEkTBtCK6qq9HHXApNaGFKokGmHbzPzCoWYMpQNN5N07opSgHse X-Received: by 10.180.100.74 with SMTP id ew10mr13622716wib.12.1437120984180; Fri, 17 Jul 2015 01:16:24 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id u7sm7309653wif.3.2015.07.17.01.16.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jul 2015 01:16:23 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger , "Lu, Wenzhuo" Date: Fri, 17 Jul 2015 10:15:12 +0200 Message-ID: <1679490.KK3tNg9jEu@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150716194920.3710f25e@urahara> References: <20150716101650.45c0e25a@urahara> <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> <20150716194920.3710f25e@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 08:16:24 -0000 2015-07-16 19:49, Stephen Hemminger: > On Fri, 17 Jul 2015 00:52:09 +0000 > "Lu, Wenzhuo" wrote: > > > Hi Stephen, > > I don't think there's a conflict. The message just reminder us that we can adjust the values to achieve better performance. > > I saw ixgbe and i40e also use 0 as the same default value. To my opinion, it's good to keep the same behavior. > > Thanks. > > In my opnion, no application should have to make special case setup > for each device type. Having to have a table that lists all the parameters > for each device name is not supportable or scaleable. > > The DPDK started out as "lets do benchmarks fast" but as a production > toolkit it needs to stop having this kind of thing. > > The message shows up to the end-user, who thinks it is a driver bug. > The "us" is now real customers not DPDK developers. +1 to have better default values and less scary messages.