DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: dev@dpdk.org, Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH 7/7] pmd: split calling mbuf free
Date: Wed, 24 Sep 2014 17:20:34 +0200
Message-ID: <16805029.uPnEfVsb0t@xps13> (raw)
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD011A99C6@BPXM14GP.gisp.nec.co.jp>

2014-09-11 07:52, Hiroshi Shimamoto:
> @@ -408,9 +408,9 @@ retry:
>  
>  		rte_compiler_barrier();
>  		p->status = MEMNIC_PKT_ST_FILLED;
> -
> -		rte_pktmbuf_free(tx_pkts[nr]);
>  	}
> +	for (i = 0; i < nr; i++)
> +		rte_pktmbuf_free(tx_pkts[i]);
>  
>  	/* stats */
>  	st->opackets += pkts;
> 

You are bursting mbuf freeing. Why title is about "split"?

-- 
Thomas

  reply	other threads:[~2014-09-24 15:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  7:52 Hiroshi Shimamoto
2014-09-24 15:20 ` Thomas Monjalon [this message]
2014-09-24 16:01   ` Wiles, Roger Keith
2014-09-25  1:12     ` Hiroshi Shimamoto
2014-09-25  2:18       ` Wiles, Roger Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16805029.uPnEfVsb0t@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=h-momma@ce.jp.nec.com \
    --cc=h-shimamoto@ct.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git