From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id B0365AFCA
 for <dev@dpdk.org>; Wed, 24 Sep 2014 17:14:29 +0200 (CEST)
Received: by mail-wg0-f49.google.com with SMTP id x12so6443743wgg.32
 for <dev@dpdk.org>; Wed, 24 Sep 2014 08:20:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=+VzSpNBN9cyPVg+6lmjWoEQaL7WAlyASXzsnnCVh/vs=;
 b=aFBdE/w+kO1JFAUtslzJEP6WkE8fMach04syXZuDSKDX2odHocGgzqcbuz0MFr9HIz
 KYhkKaYU5JmumkLwR8bV0Hx9X3wNtZ0hc0uitu47oQWgz61sVSDZUCYxB/D1ygkZgZ++
 J5TVfe8Xu+hCC7ZTt3etNWs72zsZyk+fqWUIlKglLSfwOYTiwcHEbxHXbkCZXAmek0CK
 WQ0LvhBc4y22omszMPmUhybbTvRa8q/cmBcJqDBgkgOdT09n3FPQ9zmxhEoo0wGdurIW
 dCr72nzf1+XLWe8TxcrZHoZCINJyJf0nvSKbTR4+C78SOme2Aqfkc5cTADkAjYY3+4qh
 uEmQ==
X-Gm-Message-State: ALoCoQkENnChlajIAcd+M2x/FAbBwk8I5kkQoWQvHwyDrNqKbtoLspQe0RCifcxiVu8ZEKiVX05Z
X-Received: by 10.194.171.228 with SMTP id ax4mr8689959wjc.3.1411572043207;
 Wed, 24 Sep 2014 08:20:43 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ga9sm19736153wjb.45.2014.09.24.08.20.41
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 24 Sep 2014 08:20:42 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Date: Wed, 24 Sep 2014 17:20:34 +0200
Message-ID: <16805029.uPnEfVsb0t@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD011A99C6@BPXM14GP.gisp.nec.co.jp>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD011A99C6@BPXM14GP.gisp.nec.co.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH 7/7] pmd: split calling mbuf free
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Sep 2014 15:14:29 -0000

2014-09-11 07:52, Hiroshi Shimamoto:
> @@ -408,9 +408,9 @@ retry:
>  
>  		rte_compiler_barrier();
>  		p->status = MEMNIC_PKT_ST_FILLED;
> -
> -		rte_pktmbuf_free(tx_pkts[nr]);
>  	}
> +	for (i = 0; i < nr; i++)
> +		rte_pktmbuf_free(tx_pkts[i]);
>  
>  	/* stats */
>  	st->opackets += pkts;
> 

You are bursting mbuf freeing. Why title is about "split"?

-- 
Thomas