From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A706A0524; Thu, 4 Feb 2021 16:49:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 122BF24067F; Thu, 4 Feb 2021 16:49:01 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id DDEAF240678 for ; Thu, 4 Feb 2021 16:48:58 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id E5363F63; Thu, 4 Feb 2021 10:48:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 04 Feb 2021 10:48:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 1j9yFh9QH91dM9eoqMGYORICMhdtGaVnK4JouBah3ZU=; b=KUlkdNGgHmy3ub19 P6QKyhucZBchvbX0REUIU+8REJrJdf1qxsAfBu1fRL5hLZBcumRDXaPFw5mdahDx fWHARX5qm+fnoP+YmukPUg5ITQLU/X/dK4fqBP5SUzorJ2hGQENFakrlcAA6jnoo vHD+Au0KXXtwsM2GUUiV+lNLhj8OGoQeIg71MJJ53vf7Rg+i17UwJb90FvIijkRT 33VmtClE2eg2axriuNcTZ1hthcYN/aSYpzZj46qjnxA1XIpq1R5Gf8hZLjAsYMOQ 0/stjInh1HBpWYmYOELx55Mtmr4g8CGNpKaTjq+ZABf54JDR1iA1ICZDyf3gwKlp HGRi3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1j9yFh9QH91dM9eoqMGYORICMhdtGaVnK4JouBah3 ZU=; b=Sh4o7Tm/7nYcqlMY28uPiq7jF3Iw+9N3UxW1HBdKgi1oAjbQ+S4+wHVua vT3Olw6seis3opD+iXXtgblgP0fUmKvYHTW2ZqVgv/7NBj4L4YoZW6QI8zMM2qwk Aucuqkhhc67as977ozPdBRTbJV2Byht2BgxQfZnAUySlBBO/6fNOYsbBMGYyc+8z XUSFdPiuc5XzV3vjIx1JzBKIVQUesiebodFvCykkoCupQ4inukVB9DkHGNwusa7R 4Gxq2Qh0lxSw09HKncVZkC295fVGELCekZA6idt9eOcRVXfCathQQ7iXMM7ZoQ9s I/GzAwhqbv2PpamGEKyE0xcI4ElIw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeggdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C329108005F; Thu, 4 Feb 2021 10:48:54 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson Date: Thu, 04 Feb 2021 16:48:52 +0100 Message-ID: <1680786.FbfC42XQc5@thomas> In-Reply-To: References: <20210204133435.3117-1-david.marchand@redhat.com> <10271511.8fBPl8u87h@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: select targets in build test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/02/2021 15:48, David Marchand: > On Thu, Feb 4, 2021 at 2:59 PM Thomas Monjalon wrote: > > > > 04/02/2021 14:34, David Marchand: > > > When a target compilation is broken, one way to skip the target is to > > > uninstall the associated toolchain. > > > But it is not always possible and you end up with hacking the script to > > > avoid this target until a fix is ready. > > > > > > It is also often quicker to check a fix on a failing target before > > > checking compilation on all targets. > > > > > > Introduce a variable to select targets. > > > > > > Example: > > > $ DPDK_BUILD_TEST_TARGETS=build-x86-mingw \ > > > ./devtools/test-meson-builds.sh > > > > With this solution, you need to list all targets you want to compile. > > To fill the list, it is easy, with no understand of the script internals: > $ ls $HOME/builds > build-32b build-arm64-dpaa build-arm64-octeontx2 > build-clang-static build-gcc-static build-x86-default > build-arm64-bluefield build-arm64-host-clang build-clang-shared > build-gcc-shared build-ppc64le-power8 build-x86-mingw Yes easy. > > An alternative could be to disable a target in the config file > > based on the variable DPDK_TARGET set by load_env. > > One hack, which does not need any change in the script I think, > > is to set targetcc=disabled. > > Or we could check a well defined variable after calling load-devel-config. > > A bit fragile since you are bound to this internal shell variable. > Putting logic in ~/.config/dpdk/devel.build is undocumented and more > tedious than passing an environment variable when running the script. Yes > > [...] > > > +target_is_selected build-x86-default || exit 0 > > > > Why this line? > > If the build-x86-default was not compiled in this run because you did > not select it, the call to the install target after this check > triggers a compilation of this target. OK, please add a comment. > This is not wanted from my pov, or at best confusing, because you > don't see anything with the default verbose: > > $ DPDK_BUILD_TEST_TARGETS=build-x86-mingw ./devtools/test-meson-builds.sh > ninja: Entering directory `/home/dmarchan/builds/build-x86-mingw' > [...] > Found ninja-1.10.1 at /usr/bin/ninja > [19/19] Linking target examples/dpdk-helloworld.exe > > ^^ for some time you get no output, you have the impression the script > is stuck, while it is actually compiling the build-x86-default target. > > Then, > ## Building cmdline > ## Building helloworld > ## Building l2fwd > ## Building l3fwd > ## Building multi_process > ## Building skeleton > ## Building timer > > Compiling those examples had nothing to do with the build-x86-mingw > target I was expecting.