From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D33EE42946;
Sat, 15 Apr 2023 03:16:39 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 05B7442D3D;
Sat, 15 Apr 2023 03:15:59 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id A2B83410F1
for <dev@dpdk.org>; Sat, 15 Apr 2023 03:15:49 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id 515F6217A958; Fri, 14 Apr 2023 18:15:48 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 515F6217A958
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1681521348;
bh=P2ngFHSpNuERGVeW3hUOcWOaegkLTVNf1kCcncg0qRg=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=ByB/x7RMSnTJhvyLUqPHhqDQoRtRBCRHrfKYVRQmksEBOLrNXhbeyZ0HPgpbFk0pP
H70F3c8nMSOX/kcovVUYZ3RnDb94p0FP3bI2e/QoHH7JhBPa5YXEruX+YP7NAx0UyT
qAJnDX+qOdNkQWbvJq5HRH44RVNHxwC1PDqfwAso=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, david.marchand@redhat.com, thomas@monjalon.net,
mb@smartsharesystems.com, konstantin.ananyev@huawei.com,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v6 08/15] eal: typedef cpu flag enum as int
Date: Fri, 14 Apr 2023 18:15:39 -0700
Message-Id: <1681521346-20356-9-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1681521346-20356-1-git-send-email-roretzla@linux.microsoft.com>
References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>
<1681521346-20356-1-git-send-email-roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Forward declaration of a enum is a non-standard extension and is not
supported by MSVC. Use an int instead.
Abstract the use of the int/enum rte_cpu_flag_t in function parameter
lists by re-typdefing the enum rte_cpu_flag_t to the rte_cpu_flag_t
identifier.
Remove the use of __extension__ on function prototypes where
rte_cpu_flag_t appeared in parameter lists, it is sufficient to have the
conditionally compiled __extension__ at the non-standard forward
declaration site.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/eal/include/generic/rte_cpuflags.h | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/eal/include/generic/rte_cpuflags.h b/lib/eal/include/generic/rte_cpuflags.h
index d35551e..87ab03c 100644
--- a/lib/eal/include/generic/rte_cpuflags.h
+++ b/lib/eal/include/generic/rte_cpuflags.h
@@ -44,8 +44,12 @@ struct rte_cpu_intrinsics {
/**
* Enumeration of all CPU features supported
*/
+#ifndef RTE_TOOLCHAIN_MSVC
__extension__
-enum rte_cpu_flag_t;
+typedef enum rte_cpu_flag_t rte_cpu_flag_t;
+#else
+typedef int rte_cpu_flag_t;
+#endif
/**
* Get name of CPU flag
@@ -56,9 +60,8 @@ struct rte_cpu_intrinsics {
* flag name
* NULL if flag ID is invalid
*/
-__extension__
const char *
-rte_cpu_get_flag_name(enum rte_cpu_flag_t feature);
+rte_cpu_get_flag_name(rte_cpu_flag_t feature);
/**
* Function for checking a CPU flag availability
@@ -70,9 +73,8 @@ struct rte_cpu_intrinsics {
* 0 if flag is not available
* -ENOENT if flag is invalid
*/
-__extension__
int
-rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
+rte_cpu_get_flag_enabled(rte_cpu_flag_t feature);
/**
* This function checks that the currently used CPU supports the CPU features
--
1.8.3.1