From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id E12DA2A9 for ; Tue, 28 Oct 2014 15:14:18 +0100 (CET) Received: by mail-wi0-f169.google.com with SMTP id q5so8959462wiv.4 for ; Tue, 28 Oct 2014 07:23:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=yGrFEfGDDMJJFU3mjvf45gQP34GE+pUfPZe3dNAPSpY=; b=C9izj6E+EWczDAVJcQBHHvagVKQdQujbKjX0TF6jlzblacLi4Rx2TPqKVSIqDkQA8Z uNPhTzkOAQjvrjrjoH1oCzzADdCflCZX0lYTqdAvTNEMQoZiilwiTvU2NX9Pv9FzYggF RS2diHuT+DCtHi6PdQ3EjQ2qwVvzhbsITx8rhmHwzki8C7MaclrBFmvZmXCSmHxRN2ul JzyBueEjj2aQ7XLWdZtWUGP+Y2PPlY//XqcjX74GfsyyvtPbMJwBwBmgqGqjVmRY3/jG n2JsBMy6FS4gSRv62w0a2Fyt3E4h9x/sSF8U7zFCmumIV2dn6TiIak0dPbbQfmPlL8I4 TIsA== X-Gm-Message-State: ALoCoQk0rr7vGoBATGyRJ9GVG94m63L1jWsjJSAt3MAMD7z5Iumy58apVH97ZHOaBNT7LUp58ONI X-Received: by 10.194.223.67 with SMTP id qs3mr3593914wjc.127.1414506186256; Tue, 28 Oct 2014 07:23:06 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id hz8sm2025185wjb.13.2014.10.28.07.23.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Oct 2014 07:23:05 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Tue, 28 Oct 2014 15:22:46 +0100 Message-ID: <16840005.4l2yIG62TI@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <59AF69C657FD0841A61C55336867B5B034434191@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 14:14:19 -0000 2014-10-28 13:20, Zhang, Helin: > From: Richardson, Bruce > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > > 2014-10-28 00:33, Zhang, Helin: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > 2014-09-25 16:40, Helin Zhang: > > > > > > /* Definitions used for redirection table entry size */ > > > > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > > > > > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > > > > > +#define ETH_RSS_RETA_SIZE_64 64 > > > > > > +#define ETH_RSS_RETA_SIZE_128 128 > > > > > > +#define ETH_RSS_RETA_SIZE_512 512 > > > > > > + > > > > > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) > > > > > > > > > > Are these constants really needed? > > > > > > > > These constants were defined for the third input parameter of > > > > rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). End > > > > users need > > > > to give the correct reta size listed as above, as other values is > > > > not valid. So it would be > > > > better to list the valid reta sizes in macros here. > > > > > If only limited range of values are allowed, would an enum work better than a set > > of macros? > > Good idea! Any other comments for this from other guys? I would prefer the API to be independent of the hardware capabilities. -- Thomas