From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id A1DF9108F for ; Wed, 25 Jan 2017 11:08:25 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id c206so21707049wme.0 for ; Wed, 25 Jan 2017 02:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=WG4FBFZA5RFXHdwRUoRjf1opJdDrNhWevt/RFidPyJQ=; b=UPnJbF2M+5zkVs1/9A0wJ1X8441K3r4qcfd9x0RqqaPoNQyBQbjtSMN3iZP8PYVx2k FRF+Rm1Fmu7K0c1iruEizoiSRKc3BweTDHq/F3tNX+HW9IHf8dpm/K+DfMC0IIjuvelk /1YsigmBNn7gQCWj4ERNJlP+Hl4dYXp16pwrvpqAYg4vePX76/7bIzLTFjJY7BvBtCs2 x+K1BAbgw3qgv6y/LeuYdLbB0iPFxZ73WG5HmdtqSb9z2N65E17ds/v0oTXUZrlMFdOh rwpLLfi5rjHhZhNrT5kw8klm/NNKp0M18X1/5k5NjbTDXeVuIPG/UjfNuit9ytoCvQ/T JSIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=WG4FBFZA5RFXHdwRUoRjf1opJdDrNhWevt/RFidPyJQ=; b=sWzZm2Il9lMqGPCPD4PRuqicETc4DSmaVHyANf9oUERg2oGOEPSSoPqmcs6qAvcGyD GXxCTdELsJVrRI/sGwd5RKJq9b8aMeDDKyArOPzEMGLeADpsrbWjysoteiilro6kBd1G CEn1+Tc/zSEKcZgZz6JFmxiHH1oLzla+gFmHVHCDto+L1ufdgnguTcgn8VhJ2w4Ou147 /p2E528XfBo7rd8vPlrfL0h94H7YFnMcKmhYgqnU92IV0st/AHS7H6Ih2MPSZRnzyU9y +6nJa+aC7rWOi4QVeD3xXV7Aya04Zcqu7C+2jYkGXFlfZLSH/ICo4UgIhiOL8NhMFTG8 XnJg== X-Gm-Message-State: AIkVDXIBZO9fqjYnY3PzsReZaCi/DLxcUXJFO74Zz43NzjfoZhhCtqoyybSp8RSqTcrbIngP X-Received: by 10.223.135.8 with SMTP id a8mr39314355wra.162.1485338905388; Wed, 25 Jan 2017 02:08:25 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b87sm16364779wmi.0.2017.01.25.02.08.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2017 02:08:24 -0800 (PST) From: Thomas Monjalon To: Emmanuel Roullit Cc: dev@dpdk.org Date: Wed, 25 Jan 2017 11:08:24 +0100 Message-ID: <1684540.y5zCPFlYWp@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170124210419.14084-1-emmanuel.roullit@gmail.com> References: <20170124210419.14084-1-emmanuel.roullit@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: suppress error for reference of packed members X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 10:08:25 -0000 2017-01-24 22:04, Emmanuel Roullit: > Found with clang build: > error: taking address of packed member 'mlock' of class or structure > 'rte_mem_config' may result in an unaligned pointer value > [-Werror,-Waddress-of-packed-member] > > Fixes: 29361d4c91ed ("mk: fix build with clang < 3.5") > Fixes: b2bb3a5daaac ("mk: stop on warning only in developer build") I think these references are not correct. The bug is due to a new version of clang, so no Fixes: tag is needed. You should put "clang 4" in the title. > Signed-off-by: Emmanuel Roullit > --- > > v2: > * Only apply compiler flag on clang >= 4.0 Please use --in-reply-to for grouping v2 patches with v1. > --- a/mk/toolchain/clang/rte.toolchain-compat.mk > +++ b/mk/toolchain/clang/rte.toolchain-compat.mk > +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -ge 40 && echo 1), 1) > + CC_PACKED_MEMBER_WERROR := true > +endif > --- a/mk/toolchain/clang/rte.vars.mk > +++ b/mk/toolchain/clang/rte.vars.mk > +ifeq ($(CC_PACKED_MEMBER_WERROR),true) > +WERROR_FLAGS += -Wno-address-of-packed-member > +endif So you are completely disabling the warning? Can we assume this warning is of no interest?