From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id A1BE2FE5 for ; Tue, 8 Dec 2015 01:31:48 +0100 (CET) Received: by wmww144 with SMTP id w144so9345731wmw.0 for ; Mon, 07 Dec 2015 16:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:organization:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=8Ck1JQUrrj65Fu+sCLhM2tgfOj+YbSf7up9erON42sg=; b=KcoHzuTHYzo31snW4i3bJtUfBzQ9JEV8Tp8qEGnobZW/JK4fsf9SNDlt4phnOoW8nO wjc+q0SqJYGm6bF5LJp6m8WS8eOunBqr8j1DPKD1e6hnMRiREoQ0TQ5fzollYxS+1EKV Mss2oGYcd0Lv/aT097IclulttfW0OFyETNqoFjNlDMRzS/7coO4j7Iww2y2CDMBViH/L C1Fe4/Gb+DfzDYINNKhteDgsUipFpWyIUsN5f/eE7bn4JmdLrWjQwexlznWQep6qjC1H zoiMWrA/AWFzHswT80zLzEdx5Nocq8BeMOwG04wYHJ3S8kAr+5UbGujGrzzuPi4M89aZ ANng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8Ck1JQUrrj65Fu+sCLhM2tgfOj+YbSf7up9erON42sg=; b=UWtw5L4YFDT8h41TZVa3YnVZ5AC981Eq/vIn8PF2U/yyCFv63VPVUSX5YiCz/Fgebg Rlq5xqkhJJVFMHN7lizoKljBEo3kn9wCUuZX6Ni4jiNBBjm7Zji7zIh90eaP3s85AlMK SmqqX04IomYiIdwdtMyspzg+cYwQBTaouVnPRwGZOjiJVKYykCoNzhoRjy8B2Ko3OU+i 5hdLUER8tuWE0HdDNyn5GISCwpGGrA4wyy25w8sCF6p8Krj0qjLDtyHvhehTZhw4KScB 2xGsEHUPuTfaEvWungAri2k7iUWtJDuzTI4+TUs1B+NkFD0gSUnDglkq7t1+jh7aEKDA drmA== X-Gm-Message-State: ALoCoQmurTakmvrmSKFskBZOeUKzv5nviG8IorkcrnHi/g2bUzFX98EKZ5ML10cAttYDDfgDjosVB00aEabNFOGBdmvY9xXb8w== X-Received: by 10.194.200.134 with SMTP id js6mr662969wjc.114.1449534708468; Mon, 07 Dec 2015 16:31:48 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id da10sm480722wjb.22.2015.12.07.16.31.47 for (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 16:31:47 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Tue, 08 Dec 2015 01:30:35 +0100 Message-ID: <16865404.Wo74zD9g5U@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449496140-11758-5-git-send-email-remy.horton@intel.com> References: <1449496140-11758-1-git-send-email-remy.horton@intel.com> <1449496140-11758-5-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 4/4] doc: add user-space ethtool sample app guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 00:31:48 -0000 2015-12-07 13:49, Remy Horton: > --- a/doc/guides/rel_notes/release_2_2.rst > +++ b/doc/guides/rel_notes/release_2_2.rst > @@ -243,6 +243,7 @@ Examples > > * **vhost_xen: Fixed compile error.** > > +* **ethtool: Added ethtool shim and sample application.** > > Other > ~~~~~ There are really common errors I'm fixing before applying: (seen in most of other recent patches) - When adding an item, a separation new line is needed (the double blank lines are on purpose). - A new example or driver is not an issue (should not ;), so it should be in the "features" section. - If the doc is not too large, a separate commit is not needed. I know these comments are not read but I keep the hope that the next series from other authors will meet the expectations.