From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34E82A0C41; Wed, 12 May 2021 21:16:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA28F4003F; Wed, 12 May 2021 21:16:23 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id A80E74003E for <dev@dpdk.org>; Wed, 12 May 2021 21:16:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 51FD35C00D4; Wed, 12 May 2021 15:16:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 12 May 2021 15:16:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= aTCcc+D/NYvKppFF9xRUIE+mPOVIrOElww0vAivI2ew=; b=wdpwBlwVK0QRPkzy hX9gYgPx/BpWnWGcZUgxX+aJ9Jg6JXBgb4gD3Ir9nIocgnclQAWVOEfPgCJBO7Bu BgoBBNE9jS4PdO9kjd0KuWpt2tcZwWFf82dZJkG8j9GMgm5s2NKy/24zbdNQvCtS KHO6SNaEHlcTqhXBlWjfeEEvxYNoXH360lHFwM98nvYUk+oa/HqE3qqPPySAp0Gx uwVCd1dHZhvf+43BE5lVgnNFgZhFupjZmxecD0enQeVTe8aPX9cnCpUQXI0Or6Y+ 70OJPWF0uremS+pD4OMcf886sZztoUQNuenrzDinR72WPmU7z1zXd8QPSmRuPNwf hFDIMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aTCcc+D/NYvKppFF9xRUIE+mPOVIrOElww0vAivI2 ew=; b=p9eaZcDvgbiTB4BGS40byPiQ/TKAFe9RSw/Tj3KlB6eSnah5TGIwbAfMQ fBYutJlBkEBbm/JzNWn22GIts3lyjQsdiNWye2iAb5ETFW3gg3ub8s1y1qJGi2HK s9Wa1iYYrwrGR05V/IiIsYSacx0fkfr3xpxDykzjreNiKpey03csuJFpLmdrYj+g 8YzOFJXWE9J/on638qqHgxUfc1w89f3xUfdotqokvDHwTeylvOh9M+6ZxC90/NNa KYDrjpKUDisB9kgqw/htEnVYEimFbTJ68oRX0ud7pqiTmg+m1BRu1aeRrWNBnP8M 95V/gW2bsP1GAVe1Lv1Xkb1wlNtzQ== X-ME-Sender: <xms:hCmcYEExloBGzoTCJQ28iR-irg5t5KKb_l81mPXQFq2ZteUj6eWyBw> <xme:hCmcYNV6Fb6veyZaNW6ZOcuPxSzNwoSDWs3RvSfsQG4C1Z6r7RQHBXZDy7tcVsF6U z1CSm0Rgkv9PyGiiA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehvddgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:hCmcYOICPSVyqRQRd__0I-W0tS1ud0tQF3Mi078yCB4s44HRUlKQXQ> <xmx:hCmcYGGyzJQBqGrkri-y0CMaSdljypFQoWeAOryxnm6XJnwzVkl5Rw> <xmx:hCmcYKXdGg_ltMb9N-UpXWC7TUY_IRNfqIGJCqYs7uZeyYIwXtEMKg> <xmx:hSmcYNdIiXPnCx-ui_Ko3FwziqCQ0pE4SVrgJOI8LUhJv18XB6lpfQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 May 2021 15:16:19 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Min Hu (Connor)" <humin29@huawei.com> Cc: dev@dpdk.org, bernard.iremonger@intel.com, Ferruh Yigit <ferruh.yigit@intel.com> Date: Wed, 12 May 2021 21:16:17 +0200 Message-ID: <1687158.auX57ZLpMP@thomas> In-Reply-To: <8c549935-875f-ff70-3e1f-5d56503059b7@intel.com> References: <1616830818-3127-1-git-send-email-humin29@huawei.com> <1619657448-57567-1-git-send-email-humin29@huawei.com> <8c549935-875f-ff70-3e1f-5d56503059b7@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/3] fix check of port and core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 12/05/2021 18:52, Ferruh Yigit: > On 4/29/2021 1:50 AM, Min Hu (Connor) wrote: > > Currently, some examples check that the port is on the same NUMA > > node as the polling thread for best performance. The method is > > to compare the socket id of port and that of current core. If the > > result is different, warning info will be given. > > > > But it ignores the port which is from numa node 0, that is, no > > warning info will be given if the port is from numa node 0, and > > this set of patches will fix it. > > --- > > v3: > > * change "-w" to "-a". > > > > v2: > > * add more commit info. > > > > Min Hu (Connor) (3): > > examples/flow_classify: fix check of port and core > > examples/l2fwd-cat: fix check of port and core > > examples/skeleton: fix check of port and core > > > > For series, > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Only I am not sure if it is confusing to mention from 'flow_classify' in the > commit log of 'l2fwd-cat' or 'skeleton' patches. Yes it is confusing, I'll drop these comments. The commits are still not explaining the issue is for devices on node 0, I'll reword a bit. Applied, thanks.