DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: rename Tx VLAN flags
Date: Mon, 29 Jan 2018 17:12:12 +0100	[thread overview]
Message-ID: <1688049.TrVPFdMCvN@xps> (raw)
In-Reply-To: <20180129093707.18361-1-olivier.matz@6wind.com>

29/01/2018 10:37, Olivier Matz:
> For consistency with the Rx flags, the flags PKT_TX_VLAN_PKT and
> PKT_TX_QINQ_PKT are respectively renamed as PKT_TX_VLAN and
> PKT_TX_QINQ. The old defines are deprecated but will stay for some time
> for compatibility.
> 
> Reported-by: Morten Brørup <mb@smartsharesystems.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  doc/guides/rel_notes/deprecation.rst |  4 ++++
>  lib/librte_mbuf/rte_mbuf.h           | 11 +++++++++--
>  2 files changed, 13 insertions(+), 2 deletions(-)

Applied without the deprecation notice.
The deprecation notice should be separate and wait for 3 acks.
I think we should try to group it with full cleanup of the mbuf
namespace.

      reply	other threads:[~2018-01-29 16:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 21:23 [dpdk-dev] mbuf TX VLAN flags should be renamed Morten Brørup
2018-01-22 12:53 ` Olivier Matz
2018-01-29  9:37 ` [dpdk-dev] [PATCH] mbuf: rename Tx VLAN flags Olivier Matz
2018-01-29 16:12   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1688049.TrVPFdMCvN@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).