From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FB5042DBC; Mon, 3 Jul 2023 05:02:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B97541148; Mon, 3 Jul 2023 05:02:57 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id E140E40156; Mon, 3 Jul 2023 05:02:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688353375; x=1719889375; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=SeqrCYaCfCUfpcajH5nA0Um64j1qn6yeZIA/HN/GK0o=; b=KGwYwlfyB6Mb2oDEsY9y9KSmouRj3QNZsfArvf5xQCbJ2FZeKXkrsZmQ TAG6MlVAd84+ExXpJVpduWYoNAdCyJSffFM4u5oHvVYGiYa06WTr3u80Z 6gaz8DqOrYXbm4Xepz1GhMAutAnE/RfWlNcugRYMwKjfFDt8OhmS9F/bL BrpM58JLj4+ChcP3Noflzx1z114qadGIFM+jC29ouiaVMC+1hxqQER8TO Uyo12fijcj310q06vnJEQTvtcAl90tIgHc06y1O42u575ev88ye7XwwXE ycBz0o7lYDMz0roh+m3LsTuR5nxDNubrkOn91feJ3H1WBSghGX2HULoPw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="428820079" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="428820079" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 20:02:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="788358441" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="788358441" Received: from dpdk-wenzhuo-cascadelake.sh.intel.com ([10.67.110.255]) by fmsmga004.fm.intel.com with ESMTP; 02 Jul 2023 20:02:52 -0700 From: Wenzhuo Lu To: dev@dpdk.org Cc: Wenzhuo Lu , stable@dpdk.org Subject: [PATCH v2] net/iavf: fix VLAN insertion in vector path Date: Mon, 3 Jul 2023 10:22:00 +0800 Message-Id: <1688350920-112575-1-git-send-email-wenzhuo.lu@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1687310355-130696-1-git-send-email-wenzhuo.lu@intel.com> References: <1687310355-130696-1-git-send-email-wenzhuo.lu@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org As the VLAN insertion is partially supported in vector path, the behavior is different in scalar and vector path. For a VLAN packet, if using scalar path, the new VLAN tag will be inserted after the original VLAN tag. If using vector path, the new VLAN tag is inserted before the original VLAN tag. To avoid any misleading, disable VLAN insertion in vector path. Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512") Cc: stable@dpdk.org Signed-off-by: Wenzhuo Lu --- v2: - Updated iavf.ini. doc/guides/nics/features/iavf.ini | 2 +- drivers/net/iavf/iavf_rxtx.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini index fbb5b7d..55a0216 100644 --- a/doc/guides/nics/features/iavf.ini +++ b/doc/guides/nics/features/iavf.ini @@ -24,7 +24,7 @@ RSS key update = Y RSS reta update = Y VLAN filter = Y CRC offload = Y -VLAN offload = Y +VLAN offload = P L3 checksum offload = Y L4 checksum offload = Y Timestamp offload = P diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 2bf2e32..8d4a772 100644 --- a/drivers/net/iavf/iavf_rxtx.h +++ b/drivers/net/iavf/iavf_rxtx.h @@ -27,13 +27,13 @@ #define IAVF_VPMD_TX_MAX_FREE_BUF 64 #define IAVF_TX_NO_VECTOR_FLAGS ( \ + RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ + RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ RTE_ETH_TX_OFFLOAD_TCP_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY) #define IAVF_TX_VECTOR_OFFLOAD ( \ - RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ - RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \ RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | \ RTE_ETH_TX_OFFLOAD_UDP_CKSUM | \ -- 1.8.3.1