From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id B14262E81 for ; Thu, 3 Dec 2015 14:35:36 +0100 (CET) Received: by wmec201 with SMTP id c201so22412719wme.1 for ; Thu, 03 Dec 2015 05:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=NfwjcptGhys7oUOmiDDO/qS13hdEu/+IbMGFKU8Xfsk=; b=c/MmdJcj0LOZUjRTLbxwQUwgzncinm80AqdD8iA3w6fLXv0/gUI2uqxX+44zbzg7dR aIAWEw5T+lpOycM2h1jVPrGwKrxYbhTUvgUKEkKg8zf2U+Py1LycMPxhRRgvHVY8X803 py+XODu0YeQ8S2/dsPhl3gU/XDfCSrpbMPZsxq0+/dT1tt07+7Na03o7wcd4CCcdzNpO jIKZr0WND/2Y7RbDjH1aRS1WZ4pSIkBe+IbJr8lv1XaB/MiXipV+pNcfs1YOm1uGumag 0ZOb5/blsY26755rllUvpSHvzHF/WW8GmKWnqi4rqv4AwiCWhyz3CzOa3ll98hXtToEu D/fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=NfwjcptGhys7oUOmiDDO/qS13hdEu/+IbMGFKU8Xfsk=; b=GAzZ5Hghx2OJ0RXw5FZKt5vg8yKLzGrHCRvJxFPewHJIDxxj/KiekQ0B6dZ2h6Mjle M4MRNDN+CR+SAM8dIf0SiIctY+kSEIG2G3JmgmNuOHZReWweRQn30+yY6al8VUISBthD M9IgnPxVttTxM85ohKc11CrhrYamT4+qOkKQNfHb92u1rHrpSJTstyVzGh/lrbOi3Zeb u7fw349VN2GjaairpMZYMUKG1r5ejSe4CTCZhi+E8K2vGS7+Iq6WY/QGujqDXEObRSk+ YM3YxggAZJ1vFlDaje4SyWXMwTl7LGN9+9rNWWpWfFTwwNgLx3t+/Oz6AUpXj4X7gF/q oQLg== X-Gm-Message-State: ALoCoQnwBur0Wp9Q4hebES73AT6VEp75yFAGPOYSUUTWu7ExHr8cgcC7k1EtNOTWXdYRcDxfetVA X-Received: by 10.194.71.16 with SMTP id q16mr11352446wju.49.1449149736608; Thu, 03 Dec 2015 05:35:36 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id u17sm8093116wmd.8.2015.12.03.05.35.35 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Dec 2015 05:35:35 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen , Mario Carrillo Date: Thu, 03 Dec 2015 14:34:26 +0100 Message-ID: <1688604.3zH5RcAOuN@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56604306.4080203@redhat.com> References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com> <1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com> <56604306.4080203@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/12] standard make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 13:35:36 -0000 2015-12-03 15:26, Panu Matilainen: > On 12/03/2015 07:01 AM, Thomas Monjalon wrote: > > Following the recent discussions, this is a proposal to have a standard > > installation process while keeping compatibility with most of the old > > behaviours. > > > > v2 changes: > > - fix default build dir > > - RTE_TARGET subdir in $(sdkdir). > > - better kerneldir defaults > > - fix dpdk_nic_bind symlink > > - always install doc if generated > > - doc > > - pkg/dpdk.spec > > > > Except for the minor nit about examples location (one could bikeshed on > things like these forever), seems fine to me and quick-n-dirty > conversion of my own spec didn't reveal any nasty surprises. > > It also appears more comprehensive and integrated with other workflows > than the competing patches so FWIW, you have my ACK :) Thank you. I'm going to send a v3. Mario, what is your opinion about this series?